From 34f1a9ebfb6faa4c98fb6792fb3994a18f860990 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Tue, 17 Oct 2017 09:59:35 -0400
Subject: [PATCH] Fixes #1579: Devices already assigned to a cluster cannot be
 added to a different cluster

---
 netbox/templates/virtualization/cluster_add_devices.html | 7 ++++++-
 netbox/virtualization/forms.py                           | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/netbox/templates/virtualization/cluster_add_devices.html b/netbox/templates/virtualization/cluster_add_devices.html
index 2029ea5b8..0a792e0c4 100644
--- a/netbox/templates/virtualization/cluster_add_devices.html
+++ b/netbox/templates/virtualization/cluster_add_devices.html
@@ -59,6 +59,7 @@
 <script type="text/javascript">
     $(document).ready(function() {
         var device_list = $('#id_devices');
+        var disabled_indicator = device_list.attr('disabled-indicator');
         $('#id_search').autocomplete({
             source: function(request, response) {
                 $.ajax({
@@ -70,7 +71,11 @@
                     },
                     success: function(data) {
                         response($.map(data.results, function(item) {
-                            device_list.append('<option value="' + item['id'] + '">' + item['display_name'] + '</option>');
+                            var option = $("<option></option>").attr("value", item['id']).text(item['display_name']);
+                            if (disabled_indicator && item[disabled_indicator]) {
+                                option.attr("disabled", "disabled");
+                            }
+                            device_list.append(option);
                         }));
                     }
                 });
diff --git a/netbox/virtualization/forms.py b/netbox/virtualization/forms.py
index 63561a08c..9a7185f94 100644
--- a/netbox/virtualization/forms.py
+++ b/netbox/virtualization/forms.py
@@ -210,7 +210,7 @@ class ClusterAddDevicesForm(BootstrapMixin, ChainedFieldsMixin, forms.Form):
 
         # If the Cluster is assigned to a Site, all Devices must be assigned to that Site.
         if self.cluster.site is not None:
-            for device in self.cleaned_data.get('devices'):
+            for device in self.cleaned_data.get('devices', []):
                 if device.site != self.cluster.site:
                     raise ValidationError({
                         'devices': "{} belongs to a different site ({}) than the cluster ({})".format(