NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-29 03:46:25 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Handle condition gracefully where an empty object list is passed in to draw_far_objects (e.g. orphaned cable where attached device has been deleted)

Browse Source
This commit is contained in:
Brian Tiemann 2024-12-16 19:49:53 -05:00
parent 0b9ead3e8b
commit 2c2815e5b8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
netbox/dcim/svg/cables.py
View File

@ -268,6 +268,10 @@ class CableTraceSVG:
""" """
Draw the far-end objects and its terminations and return all created nodes Draw the far-end objects and its terminations and return all created nodes
""" """
# If an empty list is passed in, return empty results so this cable can be skipped
if len(obj_list) == 0:
return [], []
# Make sure elements are sorted by name for readability # Make sure elements are sorted by name for readability
objects = sorted(obj_list, key=lambda x: str(x)) objects = sorted(obj_list, key=lambda x: str(x))
width = self.width / len(objects) width = self.width / len(objects)
@ -405,6 +409,10 @@ class CableTraceSVG:
near = [term for term in near_terminations if term.object == cable.interface_b] near = [term for term in near_terminations if term.object == cable.interface_b]
far = [term for term in far_terminations if term.object == cable.interface_a] far = [term for term in far_terminations if term.object == cable.interface_a]
# If at this point we have no near or no far terminations, this cable can't be rendered, so skip.
if not (near and far):
continue
# Select most-probable start and end position # Select most-probable start and end position
start = near[0].bottom_center start = near[0].bottom_center
end = far[0].top_center end = far[0].top_center