NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-27 10:58:37 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Raise ValidationError if parent object form data is incomplete

Browse Source
This commit is contained in:
Jason Novinger 2025-04-08 13:13:48 -05:00
parent f53e3103ff
commit 2bc636f34d
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
netbox/ipam/forms/bulk_import.py
View File

@ -612,12 +612,18 @@ class ServiceImportForm(NetBoxModelImportForm):
def clean(self): def clean(self):
super().clean() super().clean()
if (parent_ct := self.cleaned_data.get('parent_object_type')):
if (parent := self.cleaned_data.get('parent')): if (parent := self.cleaned_data.get('parent')):
self.cleaned_data['parent_object_id'] = parent.pk self.cleaned_data['parent_object_id'] = parent.pk
elif not parent and (parent_id := self.cleaned_data.get('parent_object_id')): elif (parent_id := self.cleaned_data.get('parent_object_id')):
ct = self.cleaned_data.get('parent_object_type') parent = parent_ct.model_class().objects.filter(id=parent_id).first()
parent = ct.model_class().objects.filter(id=parent_id).first()
self.cleaned_data['parent'] = parent self.cleaned_data['parent'] = parent
else:
# If a parent object type is passed and we've made it to here, then raise a validation
# error since an associated parent object or parent object id has nto be passed
raise forms.ValidationError(
_("One of parent or parent_object_id needs to be included with parent_object_type")
)
for ip_address in self.cleaned_data.get('ipaddresses', []): for ip_address in self.cleaned_data.get('ipaddresses', []):
if not ip_address.assigned_object or getattr(ip_address.assigned_object, 'parent_object') != parent: if not ip_address.assigned_object or getattr(ip_address.assigned_object, 'parent_object') != parent: