From 2bc524a2ee82355395d2768e1ba3def55d7d13b0 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Wed, 16 Sep 2020 14:25:07 -0400 Subject: [PATCH] Standardize usage of BooleanColumn --- netbox/ipam/tables.py | 2 +- netbox/utilities/tables.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/netbox/ipam/tables.py b/netbox/ipam/tables.py index d7a64f7db..afdeb5515 100644 --- a/netbox/ipam/tables.py +++ b/netbox/ipam/tables.py @@ -415,7 +415,7 @@ class IPAddressDetailTable(IPAddressTable): tenant = tables.TemplateColumn( template_code=COL_TENANT ) - assigned = tables.BooleanColumn( + assigned = BooleanColumn( accessor='assigned_object_id', verbose_name='Assigned' ) diff --git a/netbox/utilities/tables.py b/netbox/utilities/tables.py index 6df6b2e26..d1f17ff1e 100644 --- a/netbox/utilities/tables.py +++ b/netbox/utilities/tables.py @@ -114,12 +114,12 @@ class BooleanColumn(tables.Column): character. """ def render(self, value): - if value is True: + if value: rendered = '' - elif value is False: - rendered = '' - else: + elif value is None: rendered = '' + else: + rendered = '' return mark_safe(rendered)