NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-14 09:51:22 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fixes #9503: Hyperlinks in ack elevation SVGs must always use absolute URLs

Browse Source
This commit is contained in:
jeremystretch 2022-06-17 14:36:55 -04:00
parent 896ebf01b1
commit 2815eca260
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-3.2.md
View File

@ -18,6 +18,7 @@
* [#9484](https://github.com/netbox-community/netbox/issues/9484) - Include services listening on "all IPs" under IP address view * [#9484](https://github.com/netbox-community/netbox/issues/9484) - Include services listening on "all IPs" under IP address view
* [#9486](https://github.com/netbox-community/netbox/issues/9486) - Fix redirect URL when adding device components from the module view * [#9486](https://github.com/netbox-community/netbox/issues/9486) - Fix redirect URL when adding device components from the module view
* [#9495](https://github.com/netbox-community/netbox/issues/9495) - Correct link to contacts in contact groups table column * [#9495](https://github.com/netbox-community/netbox/issues/9495) - Correct link to contacts in contact groups table column
* [#9503](https://github.com/netbox-community/netbox/issues/9503) - Hyperlinks in ack elevation SVGs must always use absolute URLs
* [#9512](https://github.com/netbox-community/netbox/issues/9512) - Fix duplicate site results when searching by ASN * [#9512](https://github.com/netbox-community/netbox/issues/9512) - Fix duplicate site results when searching by ASN
* [#9524](https://github.com/netbox-community/netbox/issues/9524) - Correct order of VLAN fields under VM interface creation form * [#9524](https://github.com/netbox-community/netbox/issues/9524) - Correct order of VLAN fields under VM interface creation form
* [#9537](https://github.com/netbox-community/netbox/issues/9537) - Ensure consistent use of placeholder tag throughout UI * [#9537](https://github.com/netbox-community/netbox/issues/9537) - Ensure consistent use of placeholder tag throughout UI

10
netbox/dcim/svg.py
View File

@ -114,7 +114,7 @@ class RackElevationSVG:
# Embed front device type image if one exists # Embed front device type image if one exists
if self.include_images and device.device_type.front_image: if self.include_images and device.device_type.front_image:
image = drawing.image( image = drawing.image(
href=device.device_type.front_image.url, href='{}{}'.format(self.base_url, device.device_type.front_image.url),
insert=start, insert=start,
size=end, size=end,
class_='device-image' class_='device-image'
@ -140,7 +140,7 @@ class RackElevationSVG:
# Embed rear device type image if one exists # Embed rear device type image if one exists
if self.include_images and device.device_type.rear_image: if self.include_images and device.device_type.rear_image:
image = drawing.image( image = drawing.image(
href=device.device_type.rear_image.url, href='{}{}'.format(self.base_url, device.device_type.rear_image.url),
insert=start, insert=start,
size=end, size=end,
class_='device-image' class_='device-image'
@ -151,9 +151,9 @@ class RackElevationSVG:
stroke_width='0.2em', stroke_linejoin='round', class_='device-image-label')) stroke_width='0.2em', stroke_linejoin='round', class_='device-image-label'))
link.add(drawing.text(get_device_name(device), insert=text, fill='white', class_='device-image-label')) link.add(drawing.text(get_device_name(device), insert=text, fill='white', class_='device-image-label'))
@staticmethod def _draw_empty(self, drawing, rack, start, end, text, id_, face_id, class_, reservation):
def _draw_empty(drawing, rack, start, end, text, id_, face_id, class_, reservation): link_url = '{}{}?{}'.format(
link_url = '{}?{}'.format( self.base_url,
reverse('dcim:device_add'), reverse('dcim:device_add'),
urlencode({ urlencode({
'site': rack.site.pk, 'site': rack.site.pk,