NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-29 11:56:25 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Move continue statement to right after draw_far_objects

Browse Source
This commit is contained in:
Brian Tiemann 2024-12-16 20:00:01 -05:00
parent 2c2815e5b8
commit 25b5d70b6d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
netbox/dcim/svg/cables.py
View File

@ -370,6 +370,11 @@ class CableTraceSVG:
obj_list = {end.parent_object for end in far_ends} obj_list = {end.parent_object for end in far_ends}
parent_object_nodes, far_terminations = self.draw_far_objects(obj_list, far_ends) parent_object_nodes, far_terminations = self.draw_far_objects(obj_list, far_ends)
# If there are no far terminations, this segment can't be rendered, so skip.
if not far_terminations:
continue
for cable in links: for cable in links:
# Fill in labels and description with all available data # Fill in labels and description with all available data
description = [ description = [
@ -409,10 +414,6 @@ class CableTraceSVG:
near = [term for term in near_terminations if term.object == cable.interface_b] near = [term for term in near_terminations if term.object == cable.interface_b]
far = [term for term in far_terminations if term.object == cable.interface_a] far = [term for term in far_terminations if term.object == cable.interface_a]
# If at this point we have no near or no far terminations, this cable can't be rendered, so skip.
if not (near and far):
continue
# Select most-probable start and end position # Select most-probable start and end position
start = near[0].bottom_center start = near[0].bottom_center
end = far[0].top_center end = far[0].top_center