From 207ff89c96c506cb02d23fcf207526cb8dab5743 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@netboxlabs.com>
Date: Mon, 28 Aug 2023 15:33:39 -0400
Subject: [PATCH] Use empty lookup for position field

---
 netbox/dcim/filtersets.py       | 7 -------
 netbox/templates/dcim/rack.html | 2 +-
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/netbox/dcim/filtersets.py b/netbox/dcim/filtersets.py
index 26e527d31..5ddaf9a9a 100644
--- a/netbox/dcim/filtersets.py
+++ b/netbox/dcim/filtersets.py
@@ -909,10 +909,6 @@ class DeviceFilterSet(NetBoxModelFilterSet, TenancyFilterSet, ContactModelFilter
         queryset=Rack.objects.all(),
         label=_('Rack (ID)'),
     )
-    has_position = django_filters.BooleanFilter(
-        label=_('Has a position'),
-        method='_has_position'
-    )
     cluster_id = django_filters.ModelMultipleChoiceFilter(
         queryset=Cluster.objects.all(),
         label=_('VM cluster (ID)'),
@@ -1054,9 +1050,6 @@ class DeviceFilterSet(NetBoxModelFilterSet, TenancyFilterSet, ContactModelFilter
     def _device_bays(self, queryset, name, value):
         return queryset.exclude(devicebays__isnull=value)
 
-    def _has_position(self, queryset, name, value):
-        return queryset.exclude(position__isnull=value)
-
 
 class VirtualDeviceContextFilterSet(NetBoxModelFilterSet, TenancyFilterSet):
     device_id = django_filters.ModelMultipleChoiceFilter(
diff --git a/netbox/templates/dcim/rack.html b/netbox/templates/dcim/rack.html
index 2b7f90509..0d99e74ef 100644
--- a/netbox/templates/dcim/rack.html
+++ b/netbox/templates/dcim/rack.html
@@ -200,7 +200,7 @@
                 Non-Racked Devices
             </h5>
               <div class="card-body htmx-container table-responsive"
-                hx-get="{% url 'dcim:device_list' %}?rack_id={{ object.pk }}&has_position=False&parent_bay_id=null"
+                hx-get="{% url 'dcim:device_list' %}?rack_id={{ object.pk }}&position__empty=True&parent_bay_id=null"
                 hx-trigger="load"
               ></div>