NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-28 11:26:26 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fix validation of site in Assign Device to Cluster flow

Browse Source
This commit is contained in:
Brian Tiemann 2025-01-09 19:35:40 -05:00
parent 32422d1683
commit 1fbfea56c1
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
netbox/virtualization/forms/model_forms.py
View File

@ -1,4 +1,5 @@
from django import forms from django import forms
from django.apps import apps
from django.contrib.contenttypes.models import ContentType from django.contrib.contenttypes.models import ContentType
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
from django.utils.translation import gettext_lazy as _ from django.utils.translation import gettext_lazy as _
@ -144,16 +145,27 @@ class ClusterAddDevicesForm(forms.Form):
super().clean() super().clean()
# If the Cluster is assigned to a Site, all Devices must be assigned to that Site. # If the Cluster is assigned to a Site, all Devices must be assigned to that Site.
if self.cluster.site is not None: # This validation currently only supports Site scoping, but can be extended to Location etc. if needed.
if self.cluster.scope is not None:
for device in self.cleaned_data.get('devices', []): for device in self.cleaned_data.get('devices', []):
if device.site != self.cluster.site: device_scope = None
scope_type = None
if (
self.cluster.scope_type.model_class() == apps.get_model('dcim', 'site')
and device.site != self.cluster.scope
):
device_scope = device.site
scope_type = 'site'
if device_scope:
raise ValidationError({ raise ValidationError({
'devices': _( 'devices': _(
"{device} belongs to a different site ({device_site}) than the cluster ({cluster_site})" "{device} belongs to a different {scope_type} ({device_scope}) than the "
"cluster ({cluster_scope})"
).format( ).format(
device=device, device=device,
device_site=device.site, scope_type=scope_type,
cluster_site=self.cluster.site device_scope=device_scope,
cluster_scope=self.cluster.scope
) )
}) })