NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-26 01:06:11 -06:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

prefix is_pool check for ip assignments

Browse Source
This commit is contained in:
Jamie Murphy 2023-06-19 17:28:30 +01:00
parent cdce500d90
commit 1ea00350d7
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
netbox/ipam/forms/model_forms.py
View File

@ -362,15 +362,25 @@ class IPAddressForm(TenancyForm, NetBoxModelForm):
# Do not allow assigning a network ID or broadcast address to an interface. # Do not allow assigning a network ID or broadcast address to an interface.
if interface and (address := self.cleaned_data.get('address')): if interface and (address := self.cleaned_data.get('address')):
if address.ip == address.network: prefix_str = f"{self.instance.address.network}/{self.instance.address.prefixlen}"
msg = f"{address} is a network ID, which may not be assigned to an interface." allow_assignment_error = True
if address.version == 4 and address.prefixlen not in (31, 32): if self.instance.vrf is None:
prefix_obj = Prefix.objects.get(prefix=prefix_str)
else:
prefix_obj = Prefix.objects.get(prefix=prefix_str, vrf=self.vrf)
if prefix_obj and prefix_obj.is_pool:
allow_assignment_error = False
if allow_assignment_error:
if address.ip == address.network:
msg = f"{address} is a network ID, which may not be assigned to an interface unless the prefix is a pool."
if address.version == 4 and address.prefixlen not in (31, 32):
raise ValidationError(msg)
if address.version == 6 and address.prefixlen not in (127, 128):
raise ValidationError(msg)
if address.version == 4 and address.ip == address.broadcast and address.prefixlen not in (31, 32):
msg = f"{address} is a broadcast address, which may not be assigned to an interface unless the prefix is a pool."
raise ValidationError(msg) raise ValidationError(msg)
if address.version == 6 and address.prefixlen not in (127, 128):
raise ValidationError(msg)
if address.version == 4 and address.ip == address.broadcast and address.prefixlen not in (31, 32):
msg = f"{address} is a broadcast address, which may not be assigned to an interface."
raise ValidationError(msg)
def save(self, *args, **kwargs): def save(self, *args, **kwargs):
ipaddress = super().save(*args, **kwargs) ipaddress = super().save(*args, **kwargs)