mirror of
https://github.com/netbox-community/netbox.git
synced 2025-07-27 02:48:38 -06:00
format to autopep8 compliance
This commit is contained in:
parent
676336364e
commit
1c67c60804
@ -106,16 +106,19 @@ class RemoteUserBackend(_RemoteUserBackend):
|
|||||||
try:
|
try:
|
||||||
group_list.append(Group.objects.get(name=name))
|
group_list.append(Group.objects.get(name=name))
|
||||||
except Group.DoesNotExist:
|
except Group.DoesNotExist:
|
||||||
logging.error(f"Could not assign group {name} to remotely-authenticated user {user}: Group not found")
|
logging.error(
|
||||||
|
f"Could not assign group {name} to remotely-authenticated user {user}: Group not found")
|
||||||
if group_list:
|
if group_list:
|
||||||
user.groups.set(group_list)
|
user.groups.set(group_list)
|
||||||
logger.debug(f"Assigned groups to remotely-authenticated user {user}: {group_list}")
|
logger.debug(
|
||||||
|
f"Assigned groups to remotely-authenticated user {user}: {group_list}")
|
||||||
else:
|
else:
|
||||||
user.groups.clear()
|
user.groups.clear()
|
||||||
logger.debug(f"Stripping user {user} from Groups")
|
logger.debug(f"Stripping user {user} from Groups")
|
||||||
user.is_superuser = self._is_superuser(user)
|
user.is_superuser = self._is_superuser(user)
|
||||||
logger.debug(f"User {user} is Superuser: {user.is_superuser}")
|
logger.debug(f"User {user} is Superuser: {user.is_superuser}")
|
||||||
logger.debug(f"User {user} should be Superuser: {self._is_superuser(user)}")
|
logger.debug(
|
||||||
|
f"User {user} should be Superuser: {self._is_superuser(user)}")
|
||||||
|
|
||||||
user.is_staff = self._is_staff(user)
|
user.is_staff = self._is_staff(user)
|
||||||
logger.debug(f"User {user} is Staff: {user.is_staff}")
|
logger.debug(f"User {user} is Staff: {user.is_staff}")
|
||||||
@ -132,7 +135,8 @@ class RemoteUserBackend(_RemoteUserBackend):
|
|||||||
object with the given username is not found in the database.
|
object with the given username is not found in the database.
|
||||||
"""
|
"""
|
||||||
logger = logging.getLogger('netbox.authentication.RemoteUserBackend')
|
logger = logging.getLogger('netbox.authentication.RemoteUserBackend')
|
||||||
logger.debug(f"trying to authenticate {remote_user} with groups {remote_groups}")
|
logger.debug(
|
||||||
|
f"trying to authenticate {remote_user} with groups {remote_groups}")
|
||||||
if not remote_user:
|
if not remote_user:
|
||||||
return
|
return
|
||||||
user = None
|
user = None
|
||||||
@ -172,7 +176,8 @@ class RemoteUserBackend(_RemoteUserBackend):
|
|||||||
user_groups.add(g.name)
|
user_groups.add(g.name)
|
||||||
logger.debug(f"User {user.username} is in Groups:{user_groups}")
|
logger.debug(f"User {user.username} is in Groups:{user_groups}")
|
||||||
|
|
||||||
result = user.username in superusers or (set(user_groups) & set(superuser_groups))
|
result = user.username in superusers or (
|
||||||
|
set(user_groups) & set(superuser_groups))
|
||||||
logger.debug(f"User {user.username} in Superuser Users :{result}")
|
logger.debug(f"User {user.username} in Superuser Users :{result}")
|
||||||
return bool(result)
|
return bool(result)
|
||||||
|
|
||||||
@ -186,7 +191,8 @@ class RemoteUserBackend(_RemoteUserBackend):
|
|||||||
for g in user.groups.all():
|
for g in user.groups.all():
|
||||||
user_groups.add(g.name)
|
user_groups.add(g.name)
|
||||||
logger.debug(f"User {user.username} is in Groups:{user_groups}")
|
logger.debug(f"User {user.username} is in Groups:{user_groups}")
|
||||||
result = user.username in staff_users or (set(user_groups) & set(staff_groups))
|
result = user.username in staff_users or (
|
||||||
|
set(user_groups) & set(staff_groups))
|
||||||
logger.debug(f"User {user.username} in Staff Users :{result}")
|
logger.debug(f"User {user.username} in Staff Users :{result}")
|
||||||
return bool(result)
|
return bool(result)
|
||||||
|
|
||||||
@ -199,18 +205,22 @@ class RemoteUserBackend(_RemoteUserBackend):
|
|||||||
try:
|
try:
|
||||||
group_list.append(Group.objects.get(name=name))
|
group_list.append(Group.objects.get(name=name))
|
||||||
except Group.DoesNotExist:
|
except Group.DoesNotExist:
|
||||||
logging.error(f"Could not assign group {name} to remotely-authenticated user {user}: Group not found")
|
logging.error(
|
||||||
|
f"Could not assign group {name} to remotely-authenticated user {user}: Group not found")
|
||||||
if group_list:
|
if group_list:
|
||||||
user.groups.add(*group_list)
|
user.groups.add(*group_list)
|
||||||
logger.debug(f"Assigned groups to remotely-authenticated user {user}: {group_list}")
|
logger.debug(
|
||||||
|
f"Assigned groups to remotely-authenticated user {user}: {group_list}")
|
||||||
|
|
||||||
# Assign default object permissions to the user
|
# Assign default object permissions to the user
|
||||||
permissions_list = []
|
permissions_list = []
|
||||||
for permission_name, constraints in settings.REMOTE_AUTH_DEFAULT_PERMISSIONS.items():
|
for permission_name, constraints in settings.REMOTE_AUTH_DEFAULT_PERMISSIONS.items():
|
||||||
try:
|
try:
|
||||||
object_type, action = resolve_permission_ct(permission_name)
|
object_type, action = resolve_permission_ct(
|
||||||
|
permission_name)
|
||||||
# TODO: Merge multiple actions into a single ObjectPermission per content type
|
# TODO: Merge multiple actions into a single ObjectPermission per content type
|
||||||
obj_perm = ObjectPermission(actions=[action], constraints=constraints)
|
obj_perm = ObjectPermission(
|
||||||
|
actions=[action], constraints=constraints)
|
||||||
obj_perm.save()
|
obj_perm.save()
|
||||||
obj_perm.users.add(user)
|
obj_perm.users.add(user)
|
||||||
obj_perm.object_types.add(object_type)
|
obj_perm.object_types.add(object_type)
|
||||||
@ -221,9 +231,11 @@ class RemoteUserBackend(_RemoteUserBackend):
|
|||||||
"<app>.<action>_<model>. (Example: dcim.add_site)"
|
"<app>.<action>_<model>. (Example: dcim.add_site)"
|
||||||
)
|
)
|
||||||
if permissions_list:
|
if permissions_list:
|
||||||
logger.debug(f"Assigned permissions to remotely-authenticated user {user}: {permissions_list}")
|
logger.debug(
|
||||||
|
f"Assigned permissions to remotely-authenticated user {user}: {permissions_list}")
|
||||||
else:
|
else:
|
||||||
logger.debug(f"Skipped initial assignment of permissions and groups to remotely-authenticated user {user} as Group sync is enabled")
|
logger.debug(
|
||||||
|
f"Skipped initial assignment of permissions and groups to remotely-authenticated user {user} as Group sync is enabled")
|
||||||
|
|
||||||
return user
|
return user
|
||||||
|
|
||||||
|
@ -19,6 +19,7 @@ class LoginRequiredMiddleware(object):
|
|||||||
"""
|
"""
|
||||||
If LOGIN_REQUIRED is True, redirect all non-authenticated users to the login page.
|
If LOGIN_REQUIRED is True, redirect all non-authenticated users to the login page.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
def __init__(self, get_response):
|
def __init__(self, get_response):
|
||||||
self.get_response = get_response
|
self.get_response = get_response
|
||||||
|
|
||||||
@ -48,7 +49,8 @@ class RemoteUserMiddleware(RemoteUserMiddleware_):
|
|||||||
return settings.REMOTE_AUTH_HEADER
|
return settings.REMOTE_AUTH_HEADER
|
||||||
|
|
||||||
def process_request(self, request):
|
def process_request(self, request):
|
||||||
logger = logging.getLogger('netbox.authentication.RemoteUserMiddleware')
|
logger = logging.getLogger(
|
||||||
|
'netbox.authentication.RemoteUserMiddleware')
|
||||||
# Bypass middleware if remote authentication is not enabled
|
# Bypass middleware if remote authentication is not enabled
|
||||||
if not settings.REMOTE_AUTH_ENABLED:
|
if not settings.REMOTE_AUTH_ENABLED:
|
||||||
return
|
return
|
||||||
@ -84,7 +86,8 @@ class RemoteUserMiddleware(RemoteUserMiddleware_):
|
|||||||
# to authenticate the user.
|
# to authenticate the user.
|
||||||
if settings.REMOTE_AUTH_GROUP_SYNC_ENABLED:
|
if settings.REMOTE_AUTH_GROUP_SYNC_ENABLED:
|
||||||
logger.debug("Trying to sync Groups")
|
logger.debug("Trying to sync Groups")
|
||||||
user = auth.authenticate(request, remote_user=username, remote_groups=self._get_groups(request))
|
user = auth.authenticate(
|
||||||
|
request, remote_user=username, remote_groups=self._get_groups(request))
|
||||||
else:
|
else:
|
||||||
user = auth.authenticate(request, remote_user=username)
|
user = auth.authenticate(request, remote_user=username)
|
||||||
if user:
|
if user:
|
||||||
@ -94,9 +97,11 @@ class RemoteUserMiddleware(RemoteUserMiddleware_):
|
|||||||
auth.login(request, user)
|
auth.login(request, user)
|
||||||
|
|
||||||
def _get_groups(self, request):
|
def _get_groups(self, request):
|
||||||
logger = logging.getLogger('netbox.authentication.RemoteUserMiddleware')
|
logger = logging.getLogger(
|
||||||
|
'netbox.authentication.RemoteUserMiddleware')
|
||||||
|
|
||||||
groups_string = request.META.get(settings.REMOTE_AUTH_GROUP_HEADER, None)
|
groups_string = request.META.get(
|
||||||
|
settings.REMOTE_AUTH_GROUP_HEADER, None)
|
||||||
if groups_string:
|
if groups_string:
|
||||||
groups = groups_string.split(settings.REMOTE_AUTH_GROUP_SEPERATOR)
|
groups = groups_string.split(settings.REMOTE_AUTH_GROUP_SEPERATOR)
|
||||||
else:
|
else:
|
||||||
@ -104,6 +109,7 @@ class RemoteUserMiddleware(RemoteUserMiddleware_):
|
|||||||
logger.debug(f"Groups are {groups}")
|
logger.debug(f"Groups are {groups}")
|
||||||
return groups
|
return groups
|
||||||
|
|
||||||
|
|
||||||
class ObjectChangeMiddleware(object):
|
class ObjectChangeMiddleware(object):
|
||||||
"""
|
"""
|
||||||
This middleware performs three functions in response to an object being created, updated, or deleted:
|
This middleware performs three functions in response to an object being created, updated, or deleted:
|
||||||
@ -118,6 +124,7 @@ class ObjectChangeMiddleware(object):
|
|||||||
have been created. Conversely, deletions are acted upon immediately, so that the serialized representation of the
|
have been created. Conversely, deletions are acted upon immediately, so that the serialized representation of the
|
||||||
object is recorded before it (and any related objects) are actually deleted from the database.
|
object is recorded before it (and any related objects) are actually deleted from the database.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
def __init__(self, get_response):
|
def __init__(self, get_response):
|
||||||
self.get_response = get_response
|
self.get_response = get_response
|
||||||
|
|
||||||
@ -137,6 +144,7 @@ class APIVersionMiddleware(object):
|
|||||||
"""
|
"""
|
||||||
If the request is for an API endpoint, include the API version as a response header.
|
If the request is for an API endpoint, include the API version as a response header.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
def __init__(self, get_response):
|
def __init__(self, get_response):
|
||||||
self.get_response = get_response
|
self.get_response = get_response
|
||||||
|
|
||||||
@ -152,6 +160,7 @@ class ExceptionHandlingMiddleware(object):
|
|||||||
Intercept certain exceptions which are likely indicative of installation issues and provide helpful instructions
|
Intercept certain exceptions which are likely indicative of installation issues and provide helpful instructions
|
||||||
to the user.
|
to the user.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
def __init__(self, get_response):
|
def __init__(self, get_response):
|
||||||
self.get_response = get_response
|
self.get_response = get_response
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user