#12087 - Minor tweaks

This commit is contained in:
Daniel Sheppard 2023-04-04 09:31:54 -05:00
parent 0d5e98a38c
commit 18a1ae56f1

View File

@ -507,14 +507,14 @@ class BulkEditView(GetReturnURLMixin, BaseMultiObjectView):
for name in standard_fields:
try:
model_field = self.queryset.model._meta.get_field(name)
if isinstance(model_field, ManyToManyField):
if isinstance(model_field, (ManyToManyField, ManyToManyRel)):
m2m_fields[name] = model_field
else:
model_fields[name] = model_field
except FieldDoesNotExist:
# This form field is used to modify a field rather than set its value directly
model_field = None
model_fields[name] = None
for obj in self.queryset.filter(pk__in=form.cleaned_data['pk']):
@ -526,7 +526,6 @@ class BulkEditView(GetReturnURLMixin, BaseMultiObjectView):
for name, model_field in model_fields.items():
# Handle nullification
if name in form.nullable_fields and name in nullified_fields:
if not isinstance(model_field, ManyToManyField):
setattr(obj, name, None if model_field.null else '')
# Normal fields
elif name in form.changed_data: