Closes #14326: Move form mixins (#14327)

* Move form mixins from extras app to netbox app

* Remove obsolete extras/admin.py

netbox/extras/admin.py

@@ -1,2 +0,0 @@
-# TODO: Removing this import triggers an import loop due to how form mixins are currently organized
-from .forms import ConfigRevisionForm

netbox/extras/forms/__init__.py

@@ -3,5 +3,4 @@ from .filtersets import *
 from .bulk_edit import *
 from .bulk_import import *
 from .misc import *
-from .mixins import *
 from .scripts import *

netbox/extras/forms/filtersets.py

@@ -7,6 +7,7 @@ from dcim.models import DeviceRole, DeviceType, Location, Platform, Region, Site
 from extras.choices import *
 from extras.models import *
 from netbox.forms.base import NetBoxModelFilterSetForm
+from netbox.forms.mixins import SavedFiltersMixin
 from tenancy.models import Tenant, TenantGroup
 from utilities.forms import BOOLEAN_WITH_BLANK_CHOICES, FilterForm, add_blank_choice
 from utilities.forms.fields import (
@@ -14,7 +15,6 @@ from utilities.forms.fields import (
 )
 from utilities.forms.widgets import APISelectMultiple, DateTimePicker
 from virtualization.models import Cluster, ClusterGroup, ClusterType
-from .mixins import *
 
 __all__ = (
     'ConfigContextFilterForm',

netbox/extras/forms/mixins.py

@@ -1,88 +0,0 @@
-from django import forms
-from django.contrib.contenttypes.models import ContentType
-from django.utils.translation import gettext as _
-
-from extras.choices import *
-from extras.models import *
-from utilities.forms.fields import DynamicModelMultipleChoiceField
-
-__all__ = (
-    'CustomFieldsMixin',
-    'SavedFiltersMixin',
-    'TagsMixin',
-)
-
-
-class CustomFieldsMixin:
-    """
-    Extend a Form to include custom field support.
-
-    Attributes:
-        model: The model class
-    """
-    model = None
-
-    def __init__(self, *args, **kwargs):
-        self.custom_fields = {}
-        self.custom_field_groups = {}
-
-        super().__init__(*args, **kwargs)
-
-        self._append_customfield_fields()
-
-    def _get_content_type(self):
-        """
-        Return the ContentType of the form's model.
-        """
-        if not getattr(self, 'model', None):
-            raise NotImplementedError(f"{self.__class__.__name__} must specify a model class.")
-        return ContentType.objects.get_for_model(self.model)
-
-    def _get_custom_fields(self, content_type):
-        return CustomField.objects.filter(content_types=content_type).exclude(
-            ui_visible=CustomFieldUIVisibleChoices.HIDDEN
-        )
-
-    def _get_form_field(self, customfield):
-        return customfield.to_form_field()
-
-    def _append_customfield_fields(self):
-        """
-        Append form fields for all CustomFields assigned to this object type.
-        """
-        for customfield in self._get_custom_fields(self._get_content_type()):
-            field_name = f'cf_{customfield.name}'
-            self.fields[field_name] = self._get_form_field(customfield)
-
-            # Annotate the field in the list of CustomField form fields
-            self.custom_fields[field_name] = customfield
-            if customfield.group_name not in self.custom_field_groups:
-                self.custom_field_groups[customfield.group_name] = []
-            self.custom_field_groups[customfield.group_name].append(field_name)
-
-
-class SavedFiltersMixin(forms.Form):
-    filter_id = DynamicModelMultipleChoiceField(
-        queryset=SavedFilter.objects.all(),
-        required=False,
-        label=_('Saved Filter'),
-        query_params={
-            'usable': True,
-        }
-    )
-
-
-class TagsMixin(forms.Form):
-    tags = DynamicModelMultipleChoiceField(
-        queryset=Tag.objects.all(),
-        required=False,
-        label=_('Tags'),
-    )
-
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
-        # Limit tags to those applicable to the object type
-        content_type = ContentType.objects.get_for_model(self._meta.model)
-        if content_type and hasattr(self.fields['tags'].widget, 'add_query_param'):
-            self.fields['tags'].widget.add_query_param('for_object_type_id', content_type.pk)