NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-23 17:08:41 -06:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Fixes #7768: Validate IP address status when creating a new FHRP group

Browse Source
This commit is contained in:
jeremystretch 2021-11-08 08:40:24 -05:00
parent 2ce8ef5704
commit 17fd6e692e
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-3.1.md
View File

@ -3,6 +3,7 @@
### Bug Fixes ### Bug Fixes
* [#7756](https://github.com/netbox-community/netbox/issues/7756) - Fix AttributeError exception when editing an IP address assigned to a FHRPGroup * [#7756](https://github.com/netbox-community/netbox/issues/7756) - Fix AttributeError exception when editing an IP address assigned to a FHRPGroup
* [#7768](https://github.com/netbox-community/netbox/issues/7768) - Validate IP address status when creating a new FHRP group
* [#7771](https://github.com/netbox-community/netbox/issues/7771) - Group assignment should be optional when creating contacts via REST API * [#7771](https://github.com/netbox-community/netbox/issues/7771) - Group assignment should be optional when creating contacts via REST API
--- ---

9
netbox/ipam/forms/models.py
View File

@ -576,6 +576,15 @@ class FHRPGroupForm(BootstrapMixin, CustomFieldModelForm):
return instance return instance
def clean(self):
ip_address = self.cleaned_data['ip_address']
ip_status = self.cleaned_data['ip_status']
if ip_address and not ip_status:
raise forms.ValidationError({
'ip_status': "Status must be set when creating a new IP address."
})
class FHRPGroupAssignmentForm(BootstrapMixin, forms.ModelForm): class FHRPGroupAssignmentForm(BootstrapMixin, forms.ModelForm):
group = DynamicModelChoiceField( group = DynamicModelChoiceField(