NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-23 04:22:01 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

fixes #4647 - caching invalidation related to assinging new IP addresses to interfaces

Browse Source
This commit is contained in:
John Anderson 2020-05-15 02:45:48 -04:00
parent 2c2d6c6d47
commit 14744da8f6
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/release-notes/version-2.8.md
View File

@ -5,6 +5,8 @@ v2.8.5 (FUTURE)
### Bug Fixes ### Bug Fixes
* [#3304](https://github.com/netbox-community/netbox/issues/3304) - Fix caching invalidation issue related to device/virtual machine primary IP addresses * [#3304](https://github.com/netbox-community/netbox/issues/3304) - Fix caching invalidation issue related to device/virtual machine primary IP addresses
* [#4647](https://github.com/netbox-community/netbox/issues/4647) - Fix caching invalidation issue related to assinging new IP addresses to interfaces
--- ---

7
netbox/ipam/forms.py
View File

@ -618,7 +618,12 @@ class IPAddressForm(BootstrapMixin, TenancyForm, ReturnURLForm, CustomFieldModel
if self.instance and self.instance.interface: if self.instance and self.instance.interface:
self.fields['interface'].queryset = Interface.objects.filter( self.fields['interface'].queryset = Interface.objects.filter(
device=self.instance.interface.device, virtual_machine=self.instance.interface.virtual_machine device=self.instance.interface.device, virtual_machine=self.instance.interface.virtual_machine
) ).prefetch_related(
'device__primary_ip4',
'device__primary_ip6',
'virtual_machine__primary_ip4',
'virtual_machine__primary_ip6',
) # We prefetch the primary address fields to ensure cache invalidation does not balk on the save()
else: else:
self.fields['interface'].choices = [] self.fields['interface'].choices = []