NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-16 04:02:52 -06:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fixes #6871: Support dynamic tag types in GraphQL API

Browse Source
This commit is contained in:
jeremystretch 2021-08-03 16:27:56 -04:00
parent c411d2a9f1
commit 11836cdfb1
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-3.0.md
View File

@ -11,6 +11,7 @@
* [#6811](https://github.com/netbox-community/netbox/issues/6811) - Fix exception when editing users * [#6811](https://github.com/netbox-community/netbox/issues/6811) - Fix exception when editing users
* [#6827](https://github.com/netbox-community/netbox/issues/6827) - Fix circuit termination connection dropdown * [#6827](https://github.com/netbox-community/netbox/issues/6827) - Fix circuit termination connection dropdown
* [#6846](https://github.com/netbox-community/netbox/issues/6846) - Form-driven REST API calls should use brief mode * [#6846](https://github.com/netbox-community/netbox/issues/6846) - Form-driven REST API calls should use brief mode
* [#6871](https://github.com/netbox-community/netbox/issues/6871) - Support dynamic tag types in GraphQL API
--- ---

2
netbox/extras/graphql/mixins.py
View File

@ -39,7 +39,7 @@ class JournalEntriesMixin:
class TagsMixin: class TagsMixin:
tags = graphene.List(graphene.String) tags = graphene.List('extras.graphql.types.TagType')
def resolve_tags(self, info): def resolve_tags(self, info):
return self.tags.all() return self.tags.all()

2
netbox/utilities/testing/api.py
View File

@ -449,7 +449,7 @@ class APIViewTestCases:
if type(field) is GQLDynamic: if type(field) is GQLDynamic:
# Dynamic fields must specify a subselection # Dynamic fields must specify a subselection
fields_string += f'{field_name} {{ id }}\n' fields_string += f'{field_name} {{ id }}\n'
elif type(field.type) is GQLList and field_name not in ('tags', 'choices'): elif type(field.type) is GQLList and field_name != 'choices':
# TODO: Come up with something more elegant # TODO: Come up with something more elegant
# Temporary hack to support automated testing of reverse generic relations # Temporary hack to support automated testing of reverse generic relations
fields_string += f'{field_name} {{ id }}\n' fields_string += f'{field_name} {{ id }}\n'