NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-12-22 05:12:22 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Address PR feedback: refactor brittle test for APISelect useage
Some checks are pending
CI / build (20.x, 3.12) (push) Waiting to run
Details
CI / build (20.x, 3.13) (push) Waiting to run
Details

Browse Source 
Now checks if widget is actually APISelect, rather than trying to infer
from the class name.
This commit is contained in:
Jason Novinger
2025-11-20 06:31:19 -06:00
parent 1372ec2cdb
commit 101b9d8295
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
netbox/utilities/forms/mixins.py
View File

@@ -6,6 +6,7 @@ from django.core.validators import MaxValueValidator, MinValueValidator
from django.utils.translation import gettext_lazy as _ from django.utils.translation import gettext_lazy as _
from utilities.forms.fields import ColorField, QueryField, TagFilterField from utilities.forms.fields import ColorField, QueryField, TagFilterField
from utilities.forms.widgets.apiselect import APISelect
from utilities.forms.widgets.modifiers import MODIFIER_EMPTY_FALSE, MODIFIER_EMPTY_TRUE from utilities.forms.widgets.modifiers import MODIFIER_EMPTY_FALSE, MODIFIER_EMPTY_TRUE
__all__ = ( __all__ = (
@@ -236,7 +237,7 @@ class FilterModifierMixin:
def _is_api_widget_field(self, field): def _is_api_widget_field(self, field):
"""Check if a field uses an API-based widget.""" """Check if a field uses an API-based widget."""
if 'Dynamic' in field.__class__.__name__: if field.widget is APISelect:
return True return True
if hasattr(field.widget, 'attrs') and field.widget.attrs: if hasattr(field.widget, 'attrs') and field.widget.attrs: