NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-28 03:16:25 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix two bugs with A/AAAA auto-creating

Browse Source
This commit is contained in:
rdujardin 2016-08-08 18:34:51 +02:00
parent d14b0ec52d
commit 0fc5a2576d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
netbox/ipam/models.py
View File

@ -509,14 +509,14 @@ class IPAddress(CreatedUpdatedModel):
raise ValidationError("Duplicate IP address found in global table: {}".format(duplicate_ips.first())) raise ValidationError("Duplicate IP address found in global table: {}".format(duplicate_ips.first()))
def save(self, *args, **kwargs): def save(self, *args, **kwargs):
self.update_dns()
if self.address: if self.address:
# Infer address family from IPAddress object # Infer address family from IPAddress object
self.family = self.address.version self.family = self.address.version
super(IPAddress, self).save(*args, **kwargs)
self.update_dns()
dns_records = dns.models.Record.objects.filter(address=self) dns_records = dns.models.Record.objects.filter(address=self)
for r in dns_records: for r in dns_records:
r.save() r.save()
super(IPAddress, self).save(*args, **kwargs)
def update_dns(self): def update_dns(self):
"""Auto-create a corresponding A/AAAA DNS record (if possible) whenever the PTR field is modified""" """Auto-create a corresponding A/AAAA DNS record (if possible) whenever the PTR field is modified"""
@ -530,7 +530,7 @@ class IPAddress(CreatedUpdatedModel):
if which_zone: if which_zone:
zone_name = which_zone.name zone_name = which_zone.name
record_name = self.ptr[:-len(zone_name)] record_name = self.ptr[:-len(zone_name)] if not self.ptr.endswith('.') else self.ptr[:-len(zone_name) - 1]
if record_name.endswith('.'): if record_name.endswith('.'):
record_name = record_name[:-1] record_name = record_name[:-1]
record_type = 'A' if self.family == 4 else 'AAAA' record_type = 'A' if self.family == 4 else 'AAAA'