mirror of
https://github.com/netbox-community/netbox.git
synced 2025-07-23 17:08:41 -06:00
13845 fix device type image save (#13851)
* 13845 check original image is null in save * 13845 update delete image code
This commit is contained in:
parent
04796a6ac6
commit
0ce2b1b779
@ -4,6 +4,7 @@ import yaml
|
|||||||
from functools import cached_property
|
from functools import cached_property
|
||||||
|
|
||||||
from django.core.exceptions import ValidationError
|
from django.core.exceptions import ValidationError
|
||||||
|
from django.core.files.storage import default_storage
|
||||||
from django.core.validators import MaxValueValidator, MinValueValidator
|
from django.core.validators import MaxValueValidator, MinValueValidator
|
||||||
from django.db import models
|
from django.db import models
|
||||||
from django.db.models import F, ProtectedError
|
from django.db.models import F, ProtectedError
|
||||||
@ -332,10 +333,10 @@ class DeviceType(ImageAttachmentsMixin, PrimaryModel, WeightMixin):
|
|||||||
ret = super().save(*args, **kwargs)
|
ret = super().save(*args, **kwargs)
|
||||||
|
|
||||||
# Delete any previously uploaded image files that are no longer in use
|
# Delete any previously uploaded image files that are no longer in use
|
||||||
if self.front_image != self._original_front_image:
|
if self._original_front_image and self.front_image != self._original_front_image:
|
||||||
self._original_front_image.delete(save=False)
|
default_storage.delete(self._original_front_image)
|
||||||
if self.rear_image != self._original_rear_image:
|
if self._original_rear_image and self.rear_image != self._original_rear_image:
|
||||||
self._original_rear_image.delete(save=False)
|
default_storage.delete(self._original_rear_image)
|
||||||
|
|
||||||
return ret
|
return ret
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user