From f45e64c756050d947aa8c5196b516fff8b5dcb08 Mon Sep 17 00:00:00 2001 From: fmlshai <82157941+fmlshai@users.noreply.github.com> Date: Wed, 23 Mar 2022 14:38:26 +0100 Subject: [PATCH 1/2] Fix #8785 - allow wildcard dns records Added * to the DNSValidator regex to allow wildcard domains like *.example.com --- netbox/ipam/validators.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netbox/ipam/validators.py b/netbox/ipam/validators.py index 879e20e6a..08f62ad35 100644 --- a/netbox/ipam/validators.py +++ b/netbox/ipam/validators.py @@ -24,7 +24,7 @@ class MinPrefixLengthValidator(BaseValidator): DNSValidator = RegexValidator( - regex='^[0-9A-Za-z._-]+$', - message='Only alphanumeric characters, hyphens, periods, and underscores are allowed in DNS names', + regex='^[0-9A-Za-z*._-]+$', + message='Only alphanumeric characters, asterisks, hyphens, periods, and underscores are allowed in DNS names', code='invalid' ) From e0344e92511a42caf31d15ae9688ecf5e9db3e2a Mon Sep 17 00:00:00 2001 From: fmlshai <82157941+fmlshai@users.noreply.github.com> Date: Mon, 28 Mar 2022 15:20:19 +0200 Subject: [PATCH 2/2] Update validators.py Updated DNSValidator regex --- netbox/ipam/validators.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netbox/ipam/validators.py b/netbox/ipam/validators.py index 08f62ad35..50faea8b8 100644 --- a/netbox/ipam/validators.py +++ b/netbox/ipam/validators.py @@ -24,7 +24,7 @@ class MinPrefixLengthValidator(BaseValidator): DNSValidator = RegexValidator( - regex='^[0-9A-Za-z*._-]+$', + regex=r'^([0-9A-Za-z_-]+|\*)(\.[0-9A-Za-z_-]+)*\.?$', message='Only alphanumeric characters, asterisks, hyphens, periods, and underscores are allowed in DNS names', code='invalid' )