From 0a32800d488697d29d9777f62a03878e157a132a Mon Sep 17 00:00:00 2001 From: Thomas Fargeix Date: Sat, 15 Jun 2024 13:39:57 +0200 Subject: [PATCH] Update tests for DeviceComponentFilterSet * Use device_role filter name for DeviceComponentFilterSetTests * Add test_device_role test in InventoryItemTestCase --- netbox/dcim/tests/test_filtersets.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/netbox/dcim/tests/test_filtersets.py b/netbox/dcim/tests/test_filtersets.py index 0a22f5a82..1e2f62a74 100644 --- a/netbox/dcim/tests/test_filtersets.py +++ b/netbox/dcim/tests/test_filtersets.py @@ -32,11 +32,11 @@ class DeviceComponentFilterSetTests: params = {'device_type': [device_types[0].model, device_types[1].model]} self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2) - def test_role(self): + def test_device_role(self): role = DeviceRole.objects.all()[:2] - params = {'role_id': [role[0].pk, role[1].pk]} + params = {'device_role_id': [role[0].pk, role[1].pk]} self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2) - params = {'role': [role[0].slug, role[1].slug]} + params = {'device_role': [role[0].slug, role[1].slug]} self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2) @@ -4534,6 +4534,13 @@ class InventoryItemTestCase(TestCase, ChangeLoggedFilterSetTests): params = {'device_type': [device_types[0].model, device_types[1].model]} self.assertEqual(self.filterset(params, self.queryset).qs.count(), 4) + def test_device_role(self): + role = DeviceRole.objects.all()[:2] + params = {'device_role_id': [role[0].pk, role[1].pk]} + self.assertEqual(self.filterset(params, self.queryset).qs.count(), 4) + params = {'device_role': [role[0].slug, role[1].slug]} + self.assertEqual(self.filterset(params, self.queryset).qs.count(), 4) + def test_role(self): role = DeviceRole.objects.all()[:2] params = {'role_id': [role[0].pk, role[1].pk]}