From 06dec6a2d914f943a6b29587063bf846a34aa329 Mon Sep 17 00:00:00 2001 From: jeremystretch Date: Thu, 30 Mar 2023 09:07:56 -0400 Subject: [PATCH] Fixes #12046: Fix URL parsing for git data sources --- netbox/core/data_backends.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/netbox/core/data_backends.py b/netbox/core/data_backends.py index 96b8d7d4f..c1a326532 100644 --- a/netbox/core/data_backends.py +++ b/netbox/core/data_backends.py @@ -91,10 +91,9 @@ class GitBackend(DataBackend): username = self.params.get('username') password = self.params.get('password') if username and password: - url_components = list(urlparse(self.url)) - # Prepend username & password to netloc - url_components[1] = quote(f'{username}@{password}:') + url_components[1] - url = urlunparse(url_components) + # Add username & password to URL + parsed = urlparse(self.url) + url = f'{parsed.scheme}://{quote(username)}:{quote(password)}@{parsed.netloc}{parsed.path}' else: url = self.url