From 05e1317f5e1b95a51876a7c632c9b851a09d13ad Mon Sep 17 00:00:00 2001
From: Jason Novinger <jnovinger@gmail.com>
Date: Thu, 20 Nov 2025 05:23:50 -0600
Subject: [PATCH] Fix filter modifier form submission bug with 'action' field
 collision

Forms with a field named "action" (e.g., ObjectChangeFilterForm) were causing
the form.action property to be shadowed by the field element, resulting in
[object HTMLSelectElement] appearing in the URL path.

Use form.getAttribute('action') instead of form.action to reliably retrieve
the form's action URL without collision from form fields.

Fixes form submission on /core/changelog/ and any other forms with an 'action'
field using filter modifiers.
---
 netbox/project-static/dist/netbox.js          | Bin 385096 -> 385130 bytes
 netbox/project-static/dist/netbox.js.map      | Bin 1784403 -> 1784601 bytes
 .../src/forms/filterModifiers.ts              |   4 +++-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js
index 732082dd088ebd84b5e11ce577e9343e5047a84d..aaee869a423713f869b2119853bc43c571662a59 100644
GIT binary patch
delta 139
zcmX?cK>XDK@rD-07N#xC1;%N`I*GCQX$qNosd*(unW@DZnwp7fYQaEuUb;r2rXG-y
ztD&i;R-~6$P>`CJqEV~^m(;Y*Ni9*xx6RW_Pc3mQ0V+)@ElJf-N=z=v%+FKOtf|S<
bgRrNsHD;D%%x^zu%nZaV+s_%ZR;>X5elszZ

delta 109
zcmaELK>Wl3@rD-07N#xC1;%#yI>oX1X$qNosd*(unW@DZnwrIGYQaEuUb;rHrXG-y
ztD&i;R-~6$P>`CJqLHrym(;YLz9EN2lsiGCI!`Y#xg;|`ul<8DGZ3?E|6t5owFUrQ
C!zVfb

diff --git a/netbox/project-static/dist/netbox.js.map b/netbox/project-static/dist/netbox.js.map
index ec056f6486fba9bd9d41a3a2f383685337d59f12..436eb5365411f97f1169b7b415ccb1231da3a538 100644
GIT binary patch
delta 740
zcmZ9K-)qxQ6vv6bwspVitln+1_GatYhOtpZ#K|7+&FWT*mNv}Uu?Mp>ZKGMzHR*;r
zm`Gp<KKZbVe}<rxKK2h7KKSAvAint~K6~zMJBopCPVV{f$vG$a{>S<B*LfRC;kod9
zcp<zPUJ3`o!EoqH<YwzgRq=*z;ffWIAgJ3rjljZzhmC#DE@9Ji9NV`&7a!O`6_>sG
zE-u@aQ}VHE>{=zfV3+}f7q(q2F4J@U0C$`lbqBAAnp8i1u~)N%4-avSGgF;{2R+Kk
z-Lcp>)ILwXIYS*6S`pANXaqD08Uu}kqM*y53D6Z#40N?wXkBZYX11m&8A2XwN}7=3
z7Qbf|gAhZ>6Ovcf;7B^o9MOVRB}Yh3(FxI&EPsOdT2ayX87P@`p4yFrlS8%JEH{H>
zDbMz1(2qoo^27%9gf(2s5k3Wk_B#ENvTt#O*ijt4TP*O%0WEN3gXXxoCGx5dMaM<%
zv8l_J5-1^=ER#S#qyOXC3PzK0gLk;eo4F%i+nx3i=NL8SV>Bxn>;$75BV|t2#h3;=
z#pvm1mG-+-8Ldw|;lt|!SQ4qv*n1h_LA#T>!#>OCIuK7~=<EgiEu$&v6&sjEDXG8R
zuWWb@?M3f*cc8(*n!0MS4|8ZMSry-<K`X*;s=Y<&B)y*&3#e$#ND`@%bnke19)Tu7
VQ_bc1>FxH=*?-ae_-neY{{y*P<0$|D

delta 554
zcmaKoOD{t~6vs2(kE*xhmEPWJ7fml+2truQTsKrzB{!b2(6lL~>P^DNVz9QF@Ht3R
ziG=VCY;1*uJ+XFXQekEB%gmWG=YP)soPVVsKhsB?@B&`Qi+C|F;ibHcmtR(N=EPZ#
zv!T{K<X-e1CfB#tx?=I2)OzOhC0Bt|A`YYqaU#`74N{BLA@xWD(wKe8HQmJrLmQ?M
zr8H{Tl-fpE-bN@LnKdj*!$ySCh!LVRWXm}J$)wc8(CiVVF3?F-_+9Yi$}stHm#wKY
zmS$3Cn;9lG53H2XG`Jv>;#vc(Y(|QuSXw+|L}G%t;nn|dy=rf(LFa^1hjx+?0UbPK
zPE6<!a3rMSPySekX-D$!%exMv1LM-2JtZekD5Ytf4LxF|B~xJ>*xX`czlBRo-RH%M
z2imaJi3hZ{Wo2xYjmliF^0zZAtw;97tp~cuUt3q=p#wH+`tr*#WsBf&Tv%S1_XhJD
r3#fCZ|7T-1we~Ef7+~3ZF9ZqcKK<|k(u}lZKYXnVciDxv)*Jg9A4{)F

diff --git a/netbox/project-static/src/forms/filterModifiers.ts b/netbox/project-static/src/forms/filterModifiers.ts
index 8926a00b7..b304212f1 100644
--- a/netbox/project-static/src/forms/filterModifiers.ts
+++ b/netbox/project-static/src/forms/filterModifiers.ts
@@ -37,7 +37,9 @@ export function initFilterModifiers(): void {
         }
       }
 
-      window.location.href = `${form.action}?${params.toString()}`;
+      // Use getAttribute to avoid collision with form fields named 'action'
+      const actionUrl = form.getAttribute('action') || form.action;
+      window.location.href = `${actionUrl}?${params.toString()}`;
     });
   }
 }