From 02e142e1dea671abb5987fa37379977f61f8fcdc Mon Sep 17 00:00:00 2001 From: rdujardin Date: Fri, 22 Jul 2016 15:59:50 +0200 Subject: [PATCH] Fix zone serial updating on records bulk delete --- netbox/dns/models.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/netbox/dns/models.py b/netbox/dns/models.py index 4efb3ba90..dff771c1d 100644 --- a/netbox/dns/models.py +++ b/netbox/dns/models.py @@ -9,6 +9,9 @@ from utilities.models import CreatedUpdatedModel import time +from django.db.models.signals import pre_delete +from django.dispatch import receiver + class Zone(CreatedUpdatedModel): """ A Zone represents a DNS zone. It contains SOA data but no records, records are represented as Record objects. @@ -125,11 +128,6 @@ class Record(CreatedUpdatedModel): self.zone.save() # in order to update serial. super(Record, self).save(*args, **kwargs) - #POST_DELETE RECEIVER !!! - def delete(self, *args, **kwargs): - self.zone.save() # in order to update serial. - super(Record, self).delete(*args, **kwargs) - def to_csv(self): return ','.join([ self.zone.name, @@ -154,4 +152,8 @@ class Record(CreatedUpdatedModel): ' ; '+self.description+' ; gen by netbox ( '+time.strftime('%A %B %d %Y %H:%M:%S',time.localtime())+' ) ' ]) +@receiver(pre_delete, sender=Record) +def on_record_delete(sender, **kwargs): + kwargs['instance'].zone.save() +