From ddb47661fb95aaa450ccd4600b91ebdfb3251ff3 Mon Sep 17 00:00:00 2001 From: Holger Brunn Date: Thu, 18 Sep 2014 12:04:29 +0200 Subject: [PATCH] [ADD] support old CentOS' magic module [FIX] handle empty binary fields correctly --- attachment_preview/model/ir_attachment.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/attachment_preview/model/ir_attachment.py b/attachment_preview/model/ir_attachment.py index 09503a80..908247ff 100644 --- a/attachment_preview/model/ir_attachment.py +++ b/attachment_preview/model/ir_attachment.py @@ -42,10 +42,15 @@ class IrAttachment(Model): extension = '' if filename_field and this[filename_field]: filename, extension = os.path.splitext(this[filename_field]) + if not this[binary_field]: + result[this.id] = False + continue if not extension: try: import magic - ms = magic.open(magic.MAGIC_MIME_TYPE) + ms = magic.open( + hasattr(magic, 'MAGIC_MIME_TYPE') + and magic.MAGIC_MIME_TYPE or magic.MAGIC_MIME) ms.load() mimetype = ms.buffer( base64.b64decode(this[binary_field]))