[MIG] attachment_edit to 10.0

attachment_edit/README.rst

@@ -1,11 +1,30 @@
-.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
-   :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
-   :alt: License: AGPL-3
-
 ================
 Edit attachments
 ================
 
+.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fknowledge-lightgray.png?logo=github
+    :target: https://github.com/OCA/knowledge/tree/10.0/attachment_edit
+    :alt: OCA/knowledge
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/knowledge-10-0/knowledge-10-0-attachment_edit
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
+    :target: https://runbot.odoo-community.org/runbot/118/10.0
+    :alt: Try me on Runbot
+
+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
 This module adds a button on the records' attachment dropdown that allows to
 open the attachment's form in edit mode. This makes it convenient to edit the
 attachment's properties after upload.
@@ -13,6 +32,11 @@ attachment's properties after upload.
 On the attachment's form, a field is added to move the attachment to another
 record.
 
+**Table of contents**
+
+.. contents::
+   :local:
+
 Usage
 =====
 
@@ -22,41 +46,42 @@ an attachment in order to edit it.
 To change the resource the attachment belongs to, edit the field `Resource
 reference`.
 
-.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
-   :alt: Try me on Runbot
-   :target: https://runbot.odoo-community.org/runbot/118/8.0
-
 Bug Tracker
 ===========
 
-Bugs are tracked on `GitHub Issues
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/knowledge/issues>`_.
-<https://github.com/OCA/knowledge/issues>`_. In case of trouble, please
+In case of trouble, please check there if your issue has already been reported.
-check there if your issue has already been reported. If you spotted it first,
+If you spotted it first, help us smashing it by providing a detailed and welcomed
-help us smashing it by providing a detailed and welcomed `feedback
+`feedback <https://github.com/OCA/knowledge/issues/new?body=module:%20attachment_edit%0Aversion:%2010.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
-<https://github.com/OCA/
+
-knowledge/issues/new?body=module:%20
+Do not contact contributors directly about support or help with technical issues.
-attachment_edit%0Aversion:%20
-8.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Credits
 =======
 
+Authors
+~~~~~~~
+
+* Therp BV
+
 Contributors
-------------
+~~~~~~~~~~~~
 
 * Holger Brunn <hbrunn@therp.nl>
 
-Maintainer
+Maintainers
-----------
+~~~~~~~~~~~
+
+This module is maintained by the OCA.
 
 .. image:: https://odoo-community.org/logo.png
    :alt: Odoo Community Association
    :target: https://odoo-community.org
 
-This module is maintained by the OCA.
-
 OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-To contribute to this module, please visit https://odoo-community.org.
+This module is part of the `OCA/knowledge <https://github.com/OCA/knowledge/tree/10.0/attachment_edit>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

attachment_edit/__manifest__.py

@@ -1,15 +1,15 @@
 # -*- coding: utf-8 -*-
-# © 2015 Therp BV <http://therp.nl>
+# © 2015-2018 Therp BV <http://therp.nl>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     "name": "Edit attachments",
-    "version": "8.0.1.0.0",
+    "version": "10.0.1.0.0",
     "author": "Therp BV,Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "category": "Knowledge Management",
     "summary": "Edit attachments after upload",
     "depends": [
-        'web',
+        'attachment_action',
     ],
     "data": [
         "views/ir_attachment.xml",
@@ -18,10 +18,4 @@
     "qweb": [
         'static/src/xml/attachment_edit.xml',
     ],
-    "auto_install": False,
-    "installable": True,
-    "application": False,
-    "external_dependencies": {
-        'python': [],
-    },
 }

attachment_edit/models/ir_attachment.py

@@ -13,25 +13,27 @@ class IrAttachment(models.Model):
         string='Resource reference', compute='_compute_res_reference',
         inverse='_inverse_res_reference')
 
-    @api.one
+    @api.multi
     @api.depends('res_id', 'res_model')
     def _compute_res_reference(self):
-        if self.res_model and self.res_id:
+        for this in self:
-            self.res_reference = '%s,%s' % (self.res_model, self.res_id)
+            if this.res_model and this.res_id:
+                this.res_reference = '%s,%s' % (this.res_model, this.res_id)
 
-    @api.one
+    @api.multi
     def _inverse_res_reference(self):
-        if self.res_reference:
+        for this in self:
-            self.write({
+            if this.res_reference:
-                'res_model': self.res_reference._model._model,
+                this.write({
-                'res_id': self.res_reference.id,
+                    'res_model': this.res_reference._name,
-            })
+                    'res_id': this.res_reference.id,
-        else:
+                })
-            self.write({'res_model': False, 'res_id': False})
+            else:
+                this.write({'res_model': False, 'res_id': False})
 
     @api.model
     def _selection_res_reference(self):
         return self.env['ir.model'].search([
-            ('osv_memory', '=', False),
+            ('transient', '=', False),
             ('access_ids.group_id.users', '=', self.env.uid)
         ]).mapped(lambda rec: (rec.model, rec.name))

attachment_edit/readme/CONTRIBUTORS.rst

@@ -0,0 +1 @@
+* Holger Brunn <hbrunn@therp.nl>

attachment_edit/readme/DESCRIPTION.rst

@@ -0,0 +1,6 @@
+This module adds a button on the records' attachment dropdown that allows to
+open the attachment's form in edit mode. This makes it convenient to edit the
+attachment's properties after upload.
+
+On the attachment's form, a field is added to move the attachment to another
+record.

attachment_edit/readme/USAGE.rst

@@ -0,0 +1,5 @@
+Click the pencil that appears next to the delete button when you hover over
+an attachment in order to edit it.
+
+To change the resource the attachment belongs to, edit the field `Resource
+reference`.

attachment_edit/static/description/index.html

@@ -0,0 +1,409 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<meta name="generator" content="Docutils 0.12: http://docutils.sourceforge.net/" />
+<title>Edit attachments</title>
+<style type="text/css">
+
+/*
+:Author: David Goodger (goodger@python.org)
+:Id: $Id: html4css1.css 7614 2013-02-21 15:55:51Z milde $
+:Copyright: This stylesheet has been placed in the public domain.
+
+Default cascading style sheet for the HTML output of Docutils.
+
+See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
+customize this style sheet.
+*/
+
+/* used to remove borders from tables and images */
+.borderless, table.borderless td, table.borderless th {
+  border: 0 }
+
+table.borderless td, table.borderless th {
+  /* Override padding for "table.docutils td" with "! important".
+     The right padding separates the table cells. */
+  padding: 0 0.5em 0 0 ! important }
+
+.first {
+  /* Override more specific margin styles with "! important". */
+  margin-top: 0 ! important }
+
+.last, .with-subtitle {
+  margin-bottom: 0 ! important }
+
+.hidden {
+  display: none }
+
+a.toc-backref {
+  text-decoration: none ;
+  color: black }
+
+blockquote.epigraph {
+  margin: 2em 5em ; }
+
+dl.docutils dd {
+  margin-bottom: 0.5em }
+
+object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
+  overflow: hidden;
+}
+
+/* Uncomment (and remove this text!) to get bold-faced definition list terms
+dl.docutils dt {
+  font-weight: bold }
+*/
+
+div.abstract {
+  margin: 2em 5em }
+
+div.abstract p.topic-title {
+  font-weight: bold ;
+  text-align: center }
+
+div.admonition, div.attention, div.caution, div.danger, div.error,
+div.hint, div.important, div.note, div.tip, div.warning {
+  margin: 2em ;
+  border: medium outset ;
+  padding: 1em }
+
+div.admonition p.admonition-title, div.hint p.admonition-title,
+div.important p.admonition-title, div.note p.admonition-title,
+div.tip p.admonition-title {
+  font-weight: bold ;
+  font-family: sans-serif }
+
+div.attention p.admonition-title, div.caution p.admonition-title,
+div.danger p.admonition-title, div.error p.admonition-title,
+div.warning p.admonition-title, .code .error {
+  color: red ;
+  font-weight: bold ;
+  font-family: sans-serif }
+
+/* Uncomment (and remove this text!) to get reduced vertical space in
+   compound paragraphs.
+div.compound .compound-first, div.compound .compound-middle {
+  margin-bottom: 0.5em }
+
+div.compound .compound-last, div.compound .compound-middle {
+  margin-top: 0.5em }
+*/
+
+div.dedication {
+  margin: 2em 5em ;
+  text-align: center ;
+  font-style: italic }
+
+div.dedication p.topic-title {
+  font-weight: bold ;
+  font-style: normal }
+
+div.figure {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+div.footer, div.header {
+  clear: both;
+  font-size: smaller }
+
+div.line-block {
+  display: block ;
+  margin-top: 1em ;
+  margin-bottom: 1em }
+
+div.line-block div.line-block {
+  margin-top: 0 ;
+  margin-bottom: 0 ;
+  margin-left: 1.5em }
+
+div.sidebar {
+  margin: 0 0 0.5em 1em ;
+  border: medium outset ;
+  padding: 1em ;
+  background-color: #ffffee ;
+  width: 40% ;
+  float: right ;
+  clear: right }
+
+div.sidebar p.rubric {
+  font-family: sans-serif ;
+  font-size: medium }
+
+div.system-messages {
+  margin: 5em }
+
+div.system-messages h1 {
+  color: red }
+
+div.system-message {
+  border: medium outset ;
+  padding: 1em }
+
+div.system-message p.system-message-title {
+  color: red ;
+  font-weight: bold }
+
+div.topic {
+  margin: 2em }
+
+h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
+h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
+  margin-top: 0.4em }
+
+h1.title {
+  text-align: center }
+
+h2.subtitle {
+  text-align: center }
+
+hr.docutils {
+  width: 75% }
+
+img.align-left, .figure.align-left, object.align-left {
+  clear: left ;
+  float: left ;
+  margin-right: 1em }
+
+img.align-right, .figure.align-right, object.align-right {
+  clear: right ;
+  float: right ;
+  margin-left: 1em }
+
+img.align-center, .figure.align-center, object.align-center {
+  display: block;
+  margin-left: auto;
+  margin-right: auto;
+}
+
+.align-left {
+  text-align: left }
+
+.align-center {
+  clear: both ;
+  text-align: center }
+
+.align-right {
+  text-align: right }
+
+/* reset inner alignment in figures */
+div.align-right {
+  text-align: inherit }
+
+/* div.align-center * { */
+/*   text-align: left } */
+
+ol.simple, ul.simple {
+  margin-bottom: 1em }
+
+ol.arabic {
+  list-style: decimal }
+
+ol.loweralpha {
+  list-style: lower-alpha }
+
+ol.upperalpha {
+  list-style: upper-alpha }
+
+ol.lowerroman {
+  list-style: lower-roman }
+
+ol.upperroman {
+  list-style: upper-roman }
+
+p.attribution {
+  text-align: right ;
+  margin-left: 50% }
+
+p.caption {
+  font-style: italic }
+
+p.credits {
+  font-style: italic ;
+  font-size: smaller }
+
+p.label {
+  white-space: nowrap }
+
+p.rubric {
+  font-weight: bold ;
+  font-size: larger ;
+  color: maroon ;
+  text-align: center }
+
+p.sidebar-title {
+  font-family: sans-serif ;
+  font-weight: bold ;
+  font-size: larger }
+
+p.sidebar-subtitle {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+p.topic-title {
+  font-weight: bold }
+
+pre.address {
+  margin-bottom: 0 ;
+  margin-top: 0 ;
+  font: inherit }
+
+pre.literal-block, pre.doctest-block, pre.math, pre.code {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+pre.code .ln { color: grey; } /* line numbers */
+pre.code, code { background-color: #eeeeee }
+pre.code .comment, code .comment { color: #5C6576 }
+pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
+pre.code .literal.string, code .literal.string { color: #0C5404 }
+pre.code .name.builtin, code .name.builtin { color: #352B84 }
+pre.code .deleted, code .deleted { background-color: #DEB0A1}
+pre.code .inserted, code .inserted { background-color: #A3D289}
+
+span.classifier {
+  font-family: sans-serif ;
+  font-style: oblique }
+
+span.classifier-delimiter {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+span.interpreted {
+  font-family: sans-serif }
+
+span.option {
+  white-space: nowrap }
+
+span.pre {
+  white-space: pre }
+
+span.problematic {
+  color: red }
+
+span.section-subtitle {
+  /* font-size relative to parent (h1..h6 element) */
+  font-size: 80% }
+
+table.citation {
+  border-left: solid 1px gray;
+  margin-left: 1px }
+
+table.docinfo {
+  margin: 2em 4em }
+
+table.docutils {
+  margin-top: 0.5em ;
+  margin-bottom: 0.5em }
+
+table.footnote {
+  border-left: solid 1px black;
+  margin-left: 1px }
+
+table.docutils td, table.docutils th,
+table.docinfo td, table.docinfo th {
+  padding-left: 0.5em ;
+  padding-right: 0.5em ;
+  vertical-align: top }
+
+table.docutils th.field-name, table.docinfo th.docinfo-name {
+  font-weight: bold ;
+  text-align: left ;
+  white-space: nowrap ;
+  padding-left: 0 }
+
+/* "booktabs" style (no vertical lines) */
+table.docutils.booktabs {
+  border: 0px;
+  border-top: 2px solid;
+  border-bottom: 2px solid;
+  border-collapse: collapse;
+}
+table.docutils.booktabs * {
+  border: 0px;
+}
+table.docutils.booktabs th {
+  border-bottom: thin solid;
+  text-align: left;
+}
+
+h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
+h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
+  font-size: 100% }
+
+ul.auto-toc {
+  list-style-type: none }
+
+</style>
+</head>
+<body>
+<div class="document" id="edit-attachments">
+<h1 class="title">Edit attachments</h1>
+
+<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+!! This file is generated by oca-gen-addon-readme !!
+!! changes will be overwritten.                   !!
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/knowledge/tree/10.0/attachment_edit"><img alt="OCA/knowledge" src="https://img.shields.io/badge/github-OCA%2Fknowledge-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/knowledge-10-0/knowledge-10-0-attachment_edit"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/118/10.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
+<p>This module adds a button on the records’ attachment dropdown that allows to
+open the attachment’s form in edit mode. This makes it convenient to edit the
+attachment’s properties after upload.</p>
+<p>On the attachment’s form, a field is added to move the attachment to another
+record.</p>
+<p><strong>Table of contents</strong></p>
+<div class="contents local topic" id="contents">
+<ul class="simple">
+<li><a class="reference internal" href="#usage" id="id1">Usage</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="id2">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="id3">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="id4">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="id5">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="id6">Maintainers</a></li>
+</ul>
+</li>
+</ul>
+</div>
+<div class="section" id="usage">
+<h1><a class="toc-backref" href="#id1">Usage</a></h1>
+<p>Click the pencil that appears next to the delete button when you hover over
+an attachment in order to edit it.</p>
+<p>To change the resource the attachment belongs to, edit the field <cite>Resource
+reference</cite>.</p>
+</div>
+<div class="section" id="bug-tracker">
+<h1><a class="toc-backref" href="#id2">Bug Tracker</a></h1>
+<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/knowledge/issues">GitHub Issues</a>.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+<a class="reference external" href="https://github.com/OCA/knowledge/issues/new?body=module:%20attachment_edit%0Aversion:%2010.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<p>Do not contact contributors directly about support or help with technical issues.</p>
+</div>
+<div class="section" id="credits">
+<h1><a class="toc-backref" href="#id3">Credits</a></h1>
+<div class="section" id="authors">
+<h2><a class="toc-backref" href="#id4">Authors</a></h2>
+<ul class="simple">
+<li>Therp BV</li>
+</ul>
+</div>
+<div class="section" id="contributors">
+<h2><a class="toc-backref" href="#id5">Contributors</a></h2>
+<ul class="simple">
+<li>Holger Brunn &lt;<a class="reference external" href="mailto:hbrunn&#64;therp.nl">hbrunn&#64;therp.nl</a>&gt;</li>
+</ul>
+</div>
+<div class="section" id="maintainers">
+<h2><a class="toc-backref" href="#id6">Maintainers</a></h2>
+<p>This module is maintained by the OCA.</p>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/knowledge/tree/10.0/attachment_edit">OCA/knowledge</a> project on GitHub.</p>
+<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
+</div>
+</div>
+</div>
+</body>
+</html>

attachment_edit/static/src/css/attachment_edit.css

@@ -1,22 +0,0 @@
-.openerp .oe_sidebar .oe_dropdown_menu li .oe-sidebar-attachment-edit
-{
-    position: absolute;
-    right: 32px;
-    top: 0px;
-    display: none;
-}
-.openerp .oe_sidebar .oe_dropdown_menu li:hover .oe-sidebar-attachment-edit
-{
-    display: inherit;
-}
-.openerp .oe_sidebar .oe_dropdown_menu li .oe-sidebar-attachment-edit:hover
-{
-    text-decoration: none;
-    color: white;
-    background: #8786b7;
-    text-shadow: 0 1px 1px rgba(0, 0, 0, 0.4);
-    -moz-border-radius: 2px;
-    -webkit-border-radius: 2px;
-    border-radius: 2px;
-}
-

attachment_edit/static/src/js/attachment_edit.js

@@ -1,45 +1,22 @@
 //-*- coding: utf-8 -*-
-//############################################################################
+// (c) 2015-2018 Therp BV <http://therp.nl>
-//
+// License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-//   OpenERP, Open Source Management Solution
+odoo.define('attachment_edit', function(require) {
-//   This module copyright (C) 2015 Therp BV <http://therp.nl>.
+    var Sidebar = require('web.Sidebar');
-//
-//   This program is free software: you can redistribute it and/or modify
-//   it under the terms of the GNU Affero General Public License as
-//   published by the Free Software Foundation, either version 3 of the
-//   License, or (at your option) any later version.
-//
-//   This program is distributed in the hope that it will be useful,
-//   but WITHOUT ANY WARRANTY; without even the implied warranty of
-//   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-//   GNU Affero General Public License for more details.
-//
-//   You should have received a copy of the GNU Affero General Public License
-//   along with this program.  If not, see <http://www.gnu.org/licenses/>.
-//
-//############################################################################
 
-openerp.attachment_edit = function(instance)
+    Sidebar.include({
-{
+        on_attachments_loaded: function() {
-    instance.web.Sidebar.include(
+            this._super.apply(this, arguments);
-    {
+            this.$('.o_sidebar_edit_attachment')
-        on_attachments_loaded: function(attachments)
+                .click(this.proxy('on_attachment_edit'));
-        {
-            var result = this._super.apply(this, arguments);    
-            this.$el.find('.oe-sidebar-attachment-edit')
-                .click(this.on_attachment_edit);
-            return result;
         },
-        on_attachment_edit: function(e)
+        on_attachment_edit: function(e) {
-        {
             var $target = jQuery(e.currentTarget),
-                attachment_id = parseInt($target.attr('data-id')),
+                attachment_id = parseInt($target.attr('data-id'), 10);
-                title = $target.attr('title');
             e.preventDefault();
             e.stopPropagation();
-            this.do_action({
+            return this.do_action({
                 type: 'ir_actions.act_window',
-                name: title,
                 views: [[false, 'form']],
                 res_model: 'ir.attachment',
                 res_id: attachment_id,
@@ -48,5 +25,5 @@ openerp.attachment_edit = function(instance)
                 },
             });
         },
-    })
+    });
-}
+});

attachment_edit/static/src/xml/attachment_edit.xml

@@ -1,10 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <templates>
     <t t-extend="Sidebar">
-        <t t-jquery="a.oe_sidebar_delete_item" t-operation="before">
+        <t t-jquery="span.o_sidebar_delete_attachment" t-operation="before">
-            <a t-if="section.name == 'files' and !item.callback and item.url" href="#" class="oe-sidebar-attachment-edit" t-att-data-id="item.id" t-attf-title="Edit #{item.name}">
+            <span t-if="section.name == 'files' and widget.options.editable and !item.callback" class="fa fa-pencil o_sidebar_edit_attachment" t-att-data-id="item.id" t-attf-title="Edit #{item.name}" />
-                <img t-att-src='_s + "/web/static/src/img/pencil.gif"' width="12" height="12" border="0"/>
-            </a>
         </t>
     </t>
 </templates>

attachment_edit/tests/__init__.py

@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-
+# Copyright 2018 Therp BV <https://therp.nl>
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+from . import test_attachment_edit

attachment_edit/tests/test_attachment_edit.py

@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+# Copyright 2018 Therp BV <https://therp.nl>
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+from odoo import SUPERUSER_ID
+from odoo.tests.common import TransactionCase
+
+
+class TestAttachmentEdit(TransactionCase):
+    def test_attachment_edit(self):
+        attachment = self.env['ir.attachment'].create({
+            'name': 'attachment',
+        })
+        self.assertFalse(attachment.res_reference)
+        attachment.write({
+            'res_model': 'res.users',
+            'res_id': SUPERUSER_ID,
+        })
+        self.assertEqual(
+            attachment.res_reference, self.env.ref('base.user_root'),
+        )
+        attachment.res_reference = None
+        self.assertFalse(attachment.res_model)
+        self.assertFalse(attachment.res_id)
+        attachment.res_reference = self.env.ref('base.user_root')
+        self.assertEqual(attachment.res_model, 'res.users')
+        self.assertEqual(attachment.res_id, SUPERUSER_ID)

attachment_edit/views/ir_attachment.xml

@@ -1,14 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<openerp>
+<odoo>
-    <data>
+    <record id="view_attachment_form" model="ir.ui.view">
-        <record id="view_attachment_form" model="ir.ui.view">
+        <field name="model">ir.attachment</field>
-            <field name="model">ir.attachment</field>
+        <field name="inherit_id" ref="base.view_attachment_form" />
-            <field name="inherit_id" ref="base.view_attachment_form" />
+        <field name="arch" type="xml">
-            <field name="arch" type="xml">
+            <field name="res_model" position="before">
-                <field name="res_model" position="before">
+                <field name="res_reference" />
-                    <field name="res_reference" />
-                </field>
             </field>
-        </record>
+        </field>
-    </data>
+    </record>
-</openerp>
+</odoo>

attachment_edit/views/templates.xml

@@ -4,7 +4,6 @@
         <template id="assets_backend" name="attachment_edit assets" inherit_id="web.assets_backend">
             <xpath expr="." position="inside">
                 <script type="text/javascript" src="/attachment_edit/static/src/js/attachment_edit.js"></script>
-                <link rel="stylesheet" href="/attachment_edit/static/src/css/attachment_edit.css"/>
             </xpath>
         </template>
     </data>