[MIG] attachment_preview: Migration to 11.0

[FIX] Lint

[FIX] lint and flake

[ADD] tests

[ADD] tests

[ADD] tests

[ADD] Tests

[ADD] Package python-magic

[ADD] Tests

[FIX] Lint
This commit is contained in:
tarteo
2018-07-11 14:13:08 +02:00
committed by vancouver29
parent ae0c4ac2e9
commit ce2e7eba67
35 changed files with 2241 additions and 1374 deletions

View File

@@ -1,26 +1,15 @@
.openerp .oe_sidebar .oe_dropdown_menu li .oe-sidebar-attachment-preview
{
.o_cp_sidebar li .o_sidebar_preview_attachment {
position: absolute;
right: 18px;
top: 0px;
display: none;
top: 5px;
right: 26px;
background-color: #FFF;
}
.openerp .oe_sidebar .oe_dropdown_menu li:hover .oe-sidebar-attachment-preview
{
display: inherit;
.o_cp_sidebar .open .dropdown-menu > li > a {
padding-right: 46px;
}
.openerp .oe_sidebar .oe_dropdown_menu li .oe-sidebar-attachment-preview:hover
{
text-decoration: none;
color: white;
background: #8786b7;
text-shadow: 0 1px 1px rgba(0, 0, 0, 0.4);
-moz-border-radius: 2px;
-webkit-border-radius: 2px;
border-radius: 2px;
}
.openerp .oe-binary-preview
{
cursor: pointer;
vertical-align: middle;
.o_form_uri .fa-search {
padding-left: 5px;
padding-right: 5px;
}

View File

@@ -1,242 +1,136 @@
//-*- coding: utf-8 -*-
//############################################################################
//
// OpenERP, Open Source Management Solution
// This module copyright (C) 2014 Therp BV (<http://therp.nl>).
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
//
//############################################################################
///* Copyright 2014 Therp BV (<http://therp.nl>)
// * License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). */
openerp.attachment_preview = function(instance)
{
var _t = instance.web._t;
openerp.attachment_preview.show_preview = function(
attachment_id, attachment_url, attachment_extension,
attachment_title)
{
var url = (window.location.origin || '') +
'/attachment_preview/static/lib/ViewerJS/index.html#' +
attachment_url.replace(window.location.origin, '') +
'&title=' + encodeURIComponent(attachment_title) +
'&ext=.' + encodeURIComponent(attachment_extension);
window.open(url);
};
openerp.attachment_preview.can_preview = function(extension)
{
return jQuery.inArray(
extension,
[
'odt', 'odp', 'ods', 'fodt', 'pdf', 'ott', 'fodp', 'otp',
'fods', 'ots'
]) > -1;
};
instance.web.Sidebar.include(
{
on_attachments_loaded: function(attachments)
{
var result = this._super.apply(this, arguments);
this.$el.find('.oe-sidebar-attachment-preview')
.click(this.on_attachment_preview);
this.update_preview_buttons();
return result;
odoo.define('attachment_preview', function(require) {
'use strict';
var core = require('web.core');
var _t = core._t;
var Sidebar = require('web.Sidebar');
var basic_fields = require('web.basic_fields');
var AttachmentPreviewMixin = {
canPreview: function(extension) {
return $.inArray(
extension,
[
'odt', 'odp', 'ods', 'fodt', 'pdf', 'ott', 'fodp', 'otp',
'fods', 'ots'
]) > -1;
},
on_attachment_preview: function(e)
{
e.preventDefault();
e.stopPropagation();
showPreview: function(attachment_id, attachment_url, attachment_extension, attachment_title) {
var url = (window.location.origin || '') +
'/attachment_preview/static/lib/ViewerJS/index.html' +
'?type=' + encodeURIComponent(attachment_extension) +
'&title=' + encodeURIComponent(attachment_title) +
'#' +
attachment_url.replace(window.location.origin, '');
window.open(url);
}
};
Sidebar.include(AttachmentPreviewMixin);
Sidebar.include({
_redraw: function () {
this._super.apply(this, arguments);
this.$('.o_sidebar_preview_attachment')
.click(this._onPreviewAttachment.bind(this));
this.updatePreviewButtons();
},
_onPreviewAttachment: function(event) {
event.preventDefault();
var self = this,
$target = jQuery(e.currentTarget),
attachment_id = parseInt($target.attr('data-id')),
$target = $(event.currentTarget),
attachment_id = parseInt($target.attr('data-id'), 10),
attachment_url = $target.attr('data-url'),
attachment_extension = $target.attr('data-extension'),
attachment_title = $target.attr('data-original-title');
if(attachment_extension)
{
openerp.attachment_preview.show_preview(
attachment_id, attachment_url, attachment_extension,
attachment_title);
}
else
{
(new instance.web.Model('ir.attachment')).call(
'get_attachment_extension', [attachment_id], {})
.then(function(extension)
{
openerp.attachment_preview.show_preview(
attachment_id, attachment_url, extension);
if(attachment_extension) {
this.showPreview(attachment_id, attachment_url, attachment_extension, attachment_title);
} else {
this._rpc({
model: 'ir.attachment',
method: 'get_attachment_extension',
args: [attachment_id]
}).then(function(extension) {
self.showPreview(attachment_id, attachment_url, extension);
});
}
},
update_preview_buttons: function()
{
updatePreviewButtons: function() {
var self = this;
return (new instance.web.Model('ir.attachment')).call(
'get_attachment_extension',
[
this.$el.find('.oe-sidebar-attachment-preview')
.map(function()
{
return parseInt(jQuery(this).attr('data-id'));
})
.get()
],
{})
.then(function(extensions)
{
_(extensions).each(function(extension, id)
{
var $element = jQuery(
'a.oe-sidebar-attachment-preview[data-id="'
+ id + '"]');
if(openerp.attachment_preview.can_preview(extension))
{
$element.attr('data-extension', extension);
}
else
{
$element.remove();
}
});
return this._rpc({
model: 'ir.attachment',
method: 'get_attachment_extension',
args: [
this.$el.find('.o_sidebar_preview_attachment').map(function() {
return parseInt($(this).attr('data-id'), 10);
}).get()
]
}).then(function(extensions) {
_(extensions).each(function(extension, id) {
var $element = self.$el.find('span.o_sidebar_preview_attachment[data-id="' + id + '"]');
if (self.canPreview(extension)) {
$element.attr('data-extension', extension);
} else {
$element.remove();
}
});
},
});
instance.web.ListView.include(
{
reload_content: function()
{
var deferred = this._super.apply(this, arguments),
self = this;
deferred.then(function()
{
var $elements = self.$el.find('.oe-binary-preview');
if(!$elements.length)
{
return;
}
$elements.click(function(e)
{
e.stopPropagation();
var $target = jQuery(e.currentTarget),
attachment_id = parseInt($target.attr('data-id')),
attachment_extension = $target.attr('data-extension');
openerp.attachment_preview.show_preview(
attachment_id,
$target.siblings('a').attr('href'),
attachment_extension,
$target.attr('alt'));
});
return (new instance.web.Model('ir.attachment')).call(
'get_binary_extension',
[
$elements.attr('data-model'),
$elements
.map(function()
{
return parseInt(jQuery(this).attr('data-id'));
})
.get(),
$elements.attr('data-field'),
$elements.attr('data-filename'),
],
{})
.then(function(extensions)
{
_(extensions).each(function(extension, id)
{
var $element = $elements.filter(
'[data-id="' + id + '"]');
if(openerp.attachment_preview.can_preview(extension))
{
$element.attr('data-extension', extension);
}
else
{
$element.remove();
}
});
});
});
return deferred;
}
});
instance.web.list.Binary.include(
{
_format: function (row_data, options)
{
var link = this._super.apply(this, arguments);
link += _.template(
'<img class="oe-binary-preview" title="<%-preview_text%>" alt="<%-preview_text%>" data-id="<%-preview_id%>" data-model="<%-preview_model%>" data-field="<%-preview_field%>" data-filename="<%-preview_filename%>" src="/web/static/src/img/icons/gtk-print-preview.png" />',
{
preview_id: options.id,
preview_text: _.str.sprintf(_t('Preview %s'), this.string),
preview_model: options.model,
preview_field: this.id,
preview_filename: this.filename || '',
});
return link;
}
});
instance.web.form.FieldBinaryFile.include(
{
render_value: function()
{
this._super.apply(this, arguments);
if(this.get("effective_readonly") && this.get('value'))
{
var self = this;
(new instance.web.Model('ir.attachment')).call(
'get_binary_extension', [
this.view.dataset.model,
this.view.datarecord.id ? [this.view.datarecord.id] : [],
this.name,
this.node.attrs.filename,
],
{})
.then(function(extensions)
{
_(extensions).each(function(extension)
{
var $element = self.$el.find('.oe-binary-preview');
if(openerp.attachment_preview.can_preview(extension))
{
$element.click(function()
{
openerp.attachment_preview.show_preview(
null,
_.str.sprintf(
'/web/binary/saveas?session_id=%s&model=%s&field=%s&id=%d',
instance.session.session_id,
self.view.dataset.model,
self.name,
self.view.datarecord.id),
extension,
_.str.sprintf(_t('Preview %s'), self.field.string));
});
$element.attr('title', _.str.sprintf(_t('Preview %s'), self.field.string));
}
else
{
$element.remove();
}
});
});
}
else
{
this.$el.find('.oe-binary-preview').remove();
};
},
});
}
basic_fields.FieldBinaryFile.include(AttachmentPreviewMixin);
basic_fields.FieldBinaryFile.include({
events: _.extend({}, basic_fields.FieldBinaryFile.prototype.events, {
'click .fa-search': '_onPreview'
}),
_renderReadonly: function () {
var self = this;
this._super.apply(this, arguments);
this._getBinaryExtension().done(function(extension) {
if(self.canPreview(extension)) {
self._renderPreviewButton(extension);
}
});
},
_renderPreviewButton: function(extension) {
this.$previewBtn = $("<span/>");
this.$previewBtn.addClass('fa fa-search');
this.$previewBtn.attr('title', _.str.sprintf(_t('Preview %s'), this.field.string));
this.$previewBtn.attr('data-extension', extension);
this.$el.find('.fa-download').after(this.$previewBtn);
},
_getBinaryExtension: function () {
return this._rpc({
model: 'ir.attachment',
method: 'get_binary_extension',
args: [
this.model,
this.recordData.id,
this.name,
this.attrs.filename
]
});
},
_onPreview: function(event) {
this.showPreview(
null,
_.str.sprintf(
'/web/content?model=%s&field=%s&id=%d',
this.model,
this.name,
this.recordData.id
),
$(event.currentTarget).attr('data-extension'),
_.str.sprintf(_t('Preview %s'), this.field.string)
);
}
});
return {
AttachmentPreviewMixin: AttachmentPreviewMixin
};
});

View File

@@ -1,33 +1,14 @@
//-*- coding: utf-8 -*-
//############################################################################
//
// OpenERP, Open Source Management Solution
// This module copyright (C) 2014 Therp BV (<http://therp.nl>).
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
//
//############################################################################
/* Copyright 2014 Therp BV (<http://therp.nl>)
* License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). */
// This file contains tweaks for viewerjs itself and is not meant to be run in
// OpenERP's context
var original_Viewer = Viewer;
Viewer = function(plugin, parameters)
{
var matches = (/&title=([^&]+)&/).exec(window.location.hash);
if(matches && matches.length > 1)
{
parameters.title = decodeURIComponent(matches[1]);
}
return original_Viewer(plugin, parameters);
}
(function(original_Viewer) {
window.Viewer = function(plugin, parameters) {
if(!plugin) {
// eslint-disable-next-line no-alert
alert('Unsupported file type');
}
return original_Viewer(plugin, parameters);
};
}(window.Viewer));

View File

@@ -1,15 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<templates>
<t t-extend="Sidebar">
<t t-jquery="a.oe_sidebar_delete_item" t-operation="before">
<a t-if="section.name == 'files' and !item.callback and item.url" href="#" class="oe-sidebar-attachment-preview" t-att-data-id="item.id" t-att-data-url="item.url" t-attf-title="Preview #{item.name}">
<img t-att-src='_s + "/web/static/src/img/icons/gtk-print-preview.png"' width="12" height="12" border="0"/>
</a>
</t>
</t>
<t t-extend="FieldBinaryFile">
<t t-jquery="a.oe_form_uri" t-operation="after">
<img class="oe-binary-preview" t-att-src='_s + "/web/static/src/img/icons/gtk-print-preview.png"'/>
<t t-jquery="span.o_sidebar_delete_attachment" t-operation="before">
<span t-if="section.name == 'files' and widget.options.editable and !item.callback and item.url"
class="fa fa-search o_sidebar_preview_attachment"
t-att-data-id="item.id"
t-att-data-url="item.url"
t-attf-title="Preview #{item.name}"/>
</t>
</t>
</templates>