[FIX] Performance with browse large amounts of attachments

[FIX] Style
This commit is contained in:
Stefan Rijnhart 2015-02-18 19:02:07 +01:00
parent 07106ed8dc
commit cae6f3a9e1

View File

@ -30,7 +30,8 @@ class Attachment(orm.Model):
ids = self.search( ids = self.search(
cr, uid, [('file_type', '=', False)], context=context) cr, uid, [('file_type', '=', False)], context=context)
logging.getLogger('openerp.addons.attachment_file_type').info( logging.getLogger('openerp.addons.attachment_file_type').info(
'Found %s attachments without file type in the database.', len(ids)) 'Found %s attachments without file type in the database.',
len(ids))
self.update_file_type(cr, uid, ids, force=True, context=None) self.update_file_type(cr, uid, ids, force=True, context=None)
def update_file_type(self, cr, uid, ids, force=False, context=None): def update_file_type(self, cr, uid, ids, force=False, context=None):
@ -55,7 +56,8 @@ class Attachment(orm.Model):
magic.MAGIC_MIME_TYPE if hasattr(magic, 'MAGIC_MIME_TYPE') magic.MAGIC_MIME_TYPE if hasattr(magic, 'MAGIC_MIME_TYPE')
else magic.MAGIC_MIME) else magic.MAGIC_MIME)
ms.load() ms.load()
for attachment in self.browse(cr, uid, ids, context=context): for attachment_id in ids:
attachment = self.browse(cr, uid, attachment_id, context=context)
file_type = ms.buffer( file_type = ms.buffer(
b64decode(attachment.datas)).split(';')[0] b64decode(attachment.datas)).split(';')[0]
logger.debug( logger.debug(