NeoAnd/knowledge
1
0
Fork 0
mirror of https://github.com/OCA/knowledge.git synced 2025-12-22 21:32:18 -06:00
Code Issues Actions Packages Projects Releases Wiki Activity

[document_page_approval] FIX BUG: am_i_approver was being run as sudo(), hence always giving the user Approving rights.

Browse Source
This commit is contained in:
Iván Todorovich
2018-04-24 20:51:03 -03:00
parent 3a142e7ba2
commit 503e12ae48
2 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
document_page_approval/models/document_page_history.py
View File

@@ -41,7 +41,8 @@ class DocumentPageHistory(models.Model):
)
am_i_approver = fields.Boolean(
compute='_compute_am_i_approver'
related='page_id.am_i_approver',
related_sudo=False,
)
page_url = fields.Text(
@@ -151,13 +152,6 @@ class DocumentPageHistory(models.Model):
for rec in self:
rec.am_i_owner = (rec.create_uid == self.env.user)
@api.multi
def _compute_am_i_approver(self):
"""check if current user is a approver"""
for rec in self:
rec.am_i_approver = rec.page_id.can_user_approve_this_page(
self.env.user)
@api.multi
def _compute_page_url(self):
"""Compute the page url."""