From 44fc6d93e5bec395c1e07a45fd46f6d1cebabee4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?= Date: Mon, 22 Feb 2021 14:22:54 +0100 Subject: [PATCH] [FIX] document_page_approval: Add correct followers in history pages --- .../models/document_page_history.py | 2 +- .../readme/CONTRIBUTORS.rst | 6 +++++- .../tests/test_document_page_approval.py | 19 +++++++++++++++++++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/document_page_approval/models/document_page_history.py b/document_page_approval/models/document_page_history.py index 11f0874a..188f1ddf 100644 --- a/document_page_approval/models/document_page_history.py +++ b/document_page_approval/models/document_page_history.py @@ -85,7 +85,7 @@ class DocumentPageHistory(models.Model): users = self.env['res.users'].search([ ('groups_id', 'in', guids), ('groups_id', 'in', approver_gid.id)]) - rec.message_subscribe([u.id for u in users]) + rec.message_subscribe(partner_ids=users.mapped('partner_id').ids) rec.message_post_with_template(template.id) else: # auto-approve if approval is not required diff --git a/document_page_approval/readme/CONTRIBUTORS.rst b/document_page_approval/readme/CONTRIBUTORS.rst index 0e72ccdc..1f133d63 100644 --- a/document_page_approval/readme/CONTRIBUTORS.rst +++ b/document_page_approval/readme/CONTRIBUTORS.rst @@ -3,4 +3,8 @@ * Gervais Naoussi * Maxime Chambreuil * Iván Todorovich -* Victor M.M. Torres + +* `Tecnativa `_: + + * Victor M.M. Torres + * Víctor Martínez diff --git a/document_page_approval/tests/test_document_page_approval.py b/document_page_approval/tests/test_document_page_approval.py index f41cc6ef..bcaf60cf 100644 --- a/document_page_approval/tests/test_document_page_approval.py +++ b/document_page_approval/tests/test_document_page_approval.py @@ -15,6 +15,22 @@ class TestDocumentPageApproval(common.TransactionCase): self.env.ref('base.user_root').write({ 'groups_id': [(4, self.approver_gid.id)], }) + self.user2 = self.env["res.users"].create( + { + "name": "Test user 2", + "login": "Test user 2", + "groups_id": [ + ( + 6, + 0, + [ + self.env.ref("base.group_user").id, + self.approver_gid.id, + ], + ) + ], + } + ) # demo_approval self.category2 = self.page_obj.create({ 'name': 'This category requires approval', @@ -43,6 +59,9 @@ class TestDocumentPageApproval(common.TransactionCase): # It should automatically be in 'to approve' state self.assertEqual(chreq.state, 'to approve') + user_root = self.env.ref('base.user_root') + self.assertTrue(user_root.partner_id.id in chreq.message_partner_ids.ids) + self.assertTrue(self.user2.partner_id.id in chreq.message_partner_ids.ids) self.assertNotEqual(chreq.content, page.content) # who_am_i