From 31d95fe243ed81cac722f70294fbab6bf76abfc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Todorovich?= <ivan.todorovich@gmail.com>
Date: Fri, 20 Apr 2018 10:42:10 -0300
Subject: [PATCH] [document_page] FIX creating history when there are no
 changes made. Add history name field, to name revisions. Modified views to
 allow setting this field.

---
 document_page/models/document_page.py         | 17 ++++++++++++++---
 document_page/models/document_page_history.py |  5 +++--
 document_page/views/document_page.xml         | 14 +++++++++-----
 document_page/views/document_page_history.xml |  8 +++++---
 4 files changed, 31 insertions(+), 13 deletions(-)

diff --git a/document_page/models/document_page.py b/document_page/models/document_page.py
index 24524210..80ffd053 100644
--- a/document_page/models/document_page.py
+++ b/document_page/models/document_page.py
@@ -42,7 +42,16 @@ class DocumentPage(models.Model):
     )
 
     # no-op computed field
-    summary = fields.Char(
+    draft_name = fields.Char(
+        string='Name',
+        help='Name for the changes made',
+        compute=lambda x: x,
+        inverse=lambda x: x,
+    )
+
+    # no-op computed field
+    draft_summary = fields.Char(
+        string='Summary',
         help='Describe the changes made',
         compute=lambda x: x,
         inverse=lambda x: x,
@@ -124,10 +133,12 @@ class DocumentPage(models.Model):
     @api.multi
     def _inverse_content(self):
         for rec in self:
-            if rec.type == 'content':
+            if rec.type == 'content' and \
+                    rec.content != rec.history_head.content:
                 rec._create_history({
+                    'name': rec.draft_name,
+                    'summary': rec.draft_summary,
                     'content': rec.content,
-                    'summary': rec.summary,
                 })
 
     @api.multi
diff --git a/document_page/models/document_page_history.py b/document_page/models/document_page_history.py
index a5e70e78..00317854 100644
--- a/document_page/models/document_page_history.py
+++ b/document_page/models/document_page_history.py
@@ -14,8 +14,9 @@ class DocumentPageHistory(models.Model):
     _order = 'id DESC'
 
     page_id = fields.Many2one('document.page', 'Page', ondelete='cascade')
-    summary = fields.Char('Summary', index=True)
-    content = fields.Text("Content")
+    name = fields.Char(index=True)
+    summary = fields.Char(index=True)
+    content = fields.Text()
     diff = fields.Text(compute='_compute_diff')
 
     @api.multi
diff --git a/document_page/views/document_page.xml b/document_page/views/document_page.xml
index f19341a5..b291673e 100644
--- a/document_page/views/document_page.xml
+++ b/document_page/views/document_page.xml
@@ -54,17 +54,21 @@
                     </group>
                     <notebook>
                         <page name="content" string="Content">
-                            <label for="summary" class="oe_edit_only"/>
-                            <field name="summary" placeholder="eg: Changed ... for ..." class="oe_edit_only"/>
-                            <label for="content" class="oe_edit_only"/>
-                            <field name="content" widget="html" placeholder="e.g. Once upon a time..." required="1"
-                                   options="{'safe': True}"/>
+                            <group string="Revision" class="oe_edit_only">
+                                <field name="draft_name" placeholder="Rev 01" class="oe_edit_only" />
+                                <field name="draft_summary" placeholder="eg: Changed ... for ..." class="oe_edit_only" />
+                            </group>
+                            <div>
+                                <label for="content" class="oe_edit_only"/>
+                                <field name="content" widget="html" placeholder="e.g. Once upon a time..." required="1" options="{'safe': True}"/>
+                            </div>
                         </page>
                         <page name="history" string="History">
                             <field name="history_ids">
                                 <tree>
                                     <field name="id"/>
                                     <field name="create_date"/>
+                                    <field name="name"/>
                                     <field name="summary"/>
                                     <field name="create_uid"/>
                                 </tree>
diff --git a/document_page/views/document_page_history.xml b/document_page/views/document_page_history.xml
index b0b49faf..dd08afa2 100755
--- a/document_page/views/document_page_history.xml
+++ b/document_page/views/document_page_history.xml
@@ -9,6 +9,7 @@
             <tree string="Document History">
                 <field name="id"/>
                 <field name="page_id"/>
+                <field name="name"/>
                 <field name="summary"/>
                 <field name="create_uid"/>
                 <field name="create_date"/>
@@ -46,11 +47,12 @@
                             <field name="create_date" readonly="1"/>
                         </group>
                     </group>
+                    <group>
+                        <field name="name" placeholder="Rev 01"/>
+                        <field name="summary" placeholder="eg: Changed ... for ..."/>
+                    </group>
                     <notebook>
                         <page name="content" string="Content">
-                            <label for="summary"/>
-                            <field name="summary" placeholder="eg: Changed ... for ..."/>
-                            <label for="content"/>
                             <field name="content" widget="html" placeholder="e.g. Once upon a time..." options="{'safe': True}"/>
                         </page>
                         <page name="diff" string="Changes">