[MIG] document_page_approval: Migration to 9.0

* Lint error corrected
* test improved
* lint error corrected in test file
* readme corrected
* test improved
* test of document page history workflow added
* CI error corrected
* dreipst comment
* Migration to new api improved in model's file and data tag remove in xml file
* code totally migrate to odoo 9.0 api
* test bug fixed
* test error fixed
* Lint error improved

document_page_approval/tests/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-
+from . import test_document_page_approval, test_document_page_history_workflow

document_page_approval/tests/test_document_page_approval.py

@@ -0,0 +1,37 @@
+# -*- coding: utf-8 -*-
+from openerp.tests import common
+
+
+class TestDocumentPageApproval(common.TransactionCase):
+    """Test document page approval model."""
+
+    def test_get_display_content(self):
+        """Test page display content."""
+        # Check content of a category
+        category = self.env['document.page'].search([
+            ('name', '=', 'OpenERP Features')
+        ])
+
+        self.assertIsNotNone(category.display_content, 'a category')
+
+        # Check content of a page
+        pages = self.env['document.page'].search([
+            ('parent_id', '=', category.id)
+        ])
+        page = pages[0]
+        self.assertIsNotNone(page.display_content, 'Page content')
+
+        # Check if approval is required
+        self.assertTrue(page.is_approval_required(page) ==
+                        category.approval_required)
+
+        # Check content of an approval page
+        page.approval_required = True
+
+        self.assertIsNotNone(page.display_content, 'Page content')
+
+        # Check if approval is required
+        self.assertTrue(page.is_approval_required(page))
+
+        # Check if parent approval is required
+        self.assertTrue(page.is_parent_approval_required)

document_page_approval/tests/test_document_page_history_workflow.py

@@ -0,0 +1,67 @@
+# -*- coding: utf-8 -*-
+from openerp.tests import common
+# Import logger
+import logging
+
+# Get the logger
+_logger = logging.getLogger(__name__)
+
+
+class TestDocumentPageHistoryWorkflow(common.TransactionCase):
+    """Test document page history workflow."""
+
+    def test_can_user_approve_this_page(self):
+        """Test if a user can approve this page."""
+        category = self.env.ref('document_page.demo_category1')
+        category.approval_required = True
+        category.approver_gid = self.env.ref(
+            'document_page_approval.group_document_approver_user')
+
+        page = self.env['document.page'].create({
+            'name': 'Test Page10',
+            'content': 'A difficult test',
+            'parent_id': category.id
+        })
+
+        history = self.env['document.page.history'].search(
+            [
+                ('page_id', '=', page.id)
+            ],
+            limit=1,
+            order='create_date DESC'
+        )
+
+        self.assertTrue(history.can_user_approve_page)
+
+    def test_get_approvers_guids(self):
+        """Get approver guids."""
+        category = self.env.ref('document_page.demo_category1')
+        category.approval_required = True
+        pages = self.env['document.page.history'].search([
+            ('page_id', '=', category.id)
+        ])
+        page = pages[0]
+        approvers_guid = page.get_approvers_guids()
+        self.assertTrue(len(approvers_guid) > 0)
+
+    def test_get_approvers_email(self):
+        """Get approver email."""
+        category = self.env.ref('document_page.demo_category1')
+        category.approval_required = True
+        pages = self.env['document.page.history'].search([
+            ('page_id', '=', category.id)
+        ])
+        page = pages[0]
+        _logger.info("Email: " + str(page.get_approvers_email))
+        self.assertIsNotNone(page.get_approvers_email)
+
+    def test_get_page_url(self):
+        """Test if page url exist."""
+        category = self.env.ref('document_page.demo_category1')
+        category.approval_required = True
+        pages = self.env['document.page.history'].search([
+            ('page_id', '=', category.id)
+        ])
+        page = pages[0]
+        _logger.info("Page: " + str(page.get_page_url))
+        self.assertIsNotNone(page.get_page_url)