NeoAnd/knowledge
1
0
Fork 0
mirror of https://github.com/OCA/knowledge.git synced 2025-07-13 15:34:49 -06:00
Code Issues Actions Packages Projects Releases Wiki Activity

[16.0][FIX] document_page: Don't change last history name and summary when

Browse Source 
creating new revision of page.

Fixes an issue where editing a document.page and changing name and/or summary
(to create a new revision) also changes name and summary of the history_head.

draft_name and draft_summary are now computed fields (based on history_head)
but have set the inverse without actually setting the value, to allow setting
them when creating a new draft page.

The issue is prominently evident when using document_page_approval where
the name/summary for the new draft also change the last approved version
(aka history_head) which should not happen.
This commit is contained in:
Dimitrios T. Tanis 2025-04-22 01:10:34 +03:00
parent f262120d0e
commit 06d6817a58
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
document_page/models/document_page.py
View File

@ -36,15 +36,15 @@ class DocumentPage(models.Model):
draft_name = fields.Char(
string="Name",
help="Name for the changes made",
related="history_head.name",
readonly=False,
compute="_compute_content",
inverse="_inverse_content",
)
draft_summary = fields.Char(
string="Summary",
help="Describe the changes made",
related="history_head.summary",
readonly=False,
compute="_compute_content",
inverse="_inverse_content",
)
template = fields.Html(
@ -132,12 +132,18 @@ class DocumentPage(models.Model):
for rec in self:
if rec.type == "category":
rec.content = rec._get_page_index(link=False)
rec.draft_name = False
rec.draft_summary = False
else:
if rec.history_head:
rec.content = rec.history_head.content
rec.draft_name = rec.history_head.name
rec.draft_summary = rec.history_head.summary
else:
# html widget's default, so it doesn't trigger ghost save
rec.content = self._HTML_WIDGET_DEFAULT_VALUE
rec.draft_name = False
rec.draft_summary = False
def _inverse_content(self):
for rec in self: