From ab9e0edad684ec9ca6a15a4422ff3e01393f9ebd Mon Sep 17 00:00:00 2001 From: Henry Barreto Date: Fri, 1 Aug 2025 12:49:15 -0300 Subject: [PATCH] feat: enhance logging for proxy testing errors This commit improves the logging in the testProxy method of the ProxyController class. Now, when an Axios error occurs, the specific error message will be logged if available. For unexpected errors, the error object is included for better insight. For reference, see the "message" field in the Axios documentation: [Axios Error Handling](https://axios-http.com/docs/handling_errors). --- src/api/controllers/proxy.controller.ts | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/api/controllers/proxy.controller.ts b/src/api/controllers/proxy.controller.ts index fac00375..b6e7d153 100644 --- a/src/api/controllers/proxy.controller.ts +++ b/src/api/controllers/proxy.controller.ts @@ -53,15 +53,21 @@ export class ProxyController { httpsAgent: makeProxyAgent(proxy), }); - return response?.data !== serverIp?.data; - } catch (error) { - if (axios.isAxiosError(error) && error.response?.data) { - logger.error('testProxy error: ' + error.response.data); - } else if (axios.isAxiosError(error)) { - logger.error('testProxy error: '); + const result = response?.data !== serverIp?.data; + if (result) { + logger.info('testProxy: proxy connection successful'); } else { - logger.error('testProxy error: '); + logger.warn("testProxy: proxy connection doesn't change the origin IP"); } + + return result; + } catch (error) { + if (axios.isAxiosError(error)) { + logger.error('testProxy error: axios error: ' + error.message); + } else { + logger.error('testProxy error: unexpected error: ' + error); + } + return false; } }