NeoAnd/evo-ai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(agent_service): simplify agent configuration validation and remove unnecessary comments

Browse Source
This commit is contained in:
Davidson Gomes 2025-05-14 08:58:00 -03:00
parent 9ab001c35e
commit 198eb57032
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/schemas/schemas.py
View File

@ -221,11 +221,7 @@ class AgentBase(BaseModel):
if not isinstance(v["sub_agents"], list): if not isinstance(v["sub_agents"], list):
raise ValueError("sub_agents must be a list") raise ValueError("sub_agents must be a list")
try: return v
# Convert the dictionary to CrewAIConfig
v = CrewAIConfig(**v)
except Exception as e:
raise ValueError(f"Invalid Crew AI configuration for agent: {str(e)}")
return v return v

6
src/services/agent_service.py
View File

@ -204,6 +204,7 @@ async def create_agent(db: Session, agent: AgentCreate) -> Agent:
elif agent.type == "crew_ai": elif agent.type == "crew_ai":
if not isinstance(agent.config, dict): if not isinstance(agent.config, dict):
agent.config = {}
raise HTTPException( raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST, status_code=status.HTTP_400_BAD_REQUEST,
detail="Invalid configuration: must be an object with tasks", detail="Invalid configuration: must be an object with tasks",
@ -221,7 +222,6 @@ async def create_agent(db: Session, agent: AgentCreate) -> Agent:
detail="Invalid configuration: tasks cannot be empty", detail="Invalid configuration: tasks cannot be empty",
) )
# Validar se todos os agent_id nas tasks existem
for task in agent.config["tasks"]: for task in agent.config["tasks"]:
if "agent_id" not in task: if "agent_id" not in task:
raise HTTPException( raise HTTPException(
@ -237,7 +237,6 @@ async def create_agent(db: Session, agent: AgentCreate) -> Agent:
detail=f"Agent not found for task: {agent_id}", detail=f"Agent not found for task: {agent_id}",
) )
# Validar sub_agents se existir
if "sub_agents" in agent.config and agent.config["sub_agents"]: if "sub_agents" in agent.config and agent.config["sub_agents"]:
if not validate_sub_agents(db, agent.config["sub_agents"]): if not validate_sub_agents(db, agent.config["sub_agents"]):
raise HTTPException( raise HTTPException(
@ -245,7 +244,6 @@ async def create_agent(db: Session, agent: AgentCreate) -> Agent:
detail="One or more sub-agents do not exist", detail="One or more sub-agents do not exist",
) )
# Gerar API key se não existir
if "api_key" not in agent.config or not agent.config["api_key"]: if "api_key" not in agent.config or not agent.config["api_key"]:
agent.config["api_key"] = generate_api_key() agent.config["api_key"] = generate_api_key()
@ -684,7 +682,6 @@ async def update_agent(
if "config" not in agent_data: if "config" not in agent_data:
agent_data["config"] = agent_config agent_data["config"] = agent_config
# Validar configuração de crew_ai, se aplicável
if ("type" in agent_data and agent_data["type"] == "crew_ai") or ( if ("type" in agent_data and agent_data["type"] == "crew_ai") or (
agent.type == "crew_ai" and "config" in agent_data agent.type == "crew_ai" and "config" in agent_data
): ):
@ -701,7 +698,6 @@ async def update_agent(
detail="Invalid configuration: tasks cannot be empty", detail="Invalid configuration: tasks cannot be empty",
) )
# Validar se todos os agent_id nas tasks existem
for task in config["tasks"]: for task in config["tasks"]:
if "agent_id" not in task: if "agent_id" not in task:
raise HTTPException( raise HTTPException(