From eff5903175b8ac7bf2d4db59db0bedc859645be2 Mon Sep 17 00:00:00 2001 From: Nilesh <90758938+knileshh@users.noreply.github.com> Date: Fri, 2 May 2025 17:35:10 -0700 Subject: [PATCH] Copybara import of the project: -- 6c3b8b5fa2eb9805c6f723f560e5526649dd61f0 by knileshh : fix: Correct various typos in CHANGELOG.md and test_rest_api_tool.py Corrected the following spelling errors: - CHANGELOG.md: "impprovements" -> "improvements" - test_rest_api_tool.py: "def sample_endpiont:" -> "def sample_endpoint:" - CHANGELOG.md: "credentails" -> "credentials" - CHANGELOG.md: "auido" -> "audio" COPYBARA_INTEGRATE_REVIEW=https://github.com/google/adk-python/pull/498 from knileshh:main caadbdbd78e3dc757b494f3f4d45991e88eac30d PiperOrigin-RevId: 754189420 --- CHANGELOG.md | 6 +++--- CONTRIBUTING.md | 12 ++++++------ .../openapi_spec_parser/test_rest_api_tool.py | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02fe6d9..d04235f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,7 +27,7 @@ ### ⚠ BREAKING CHANGES * Auth: expose `access_token` and `refresh_token` at top level of auth - credentails, instead of a `dict` + credentials, instead of a `dict` ([commit](https://github.com/google/adk-python/commit/956fb912e8851b139668b1ccb8db10fd252a6990)). ### Features @@ -50,7 +50,7 @@ ### Miscellaneous Chores -* README.md impprovements. +* README.md improvements. * Various code improvements. * Various typo fixes. * Bump min version of google-genai to 1.11.0. @@ -108,4 +108,4 @@ * Built-in evaluation support * Development UI that makes local development easy * Deploy to Google Cloud Run, Agent Engine -* (Experimental) Live(Bidi) auido/video agent support and Compositional Function Calling(CFC) support +* (Experimental) Live(Bidi) audio/video agent support and Compositional Function Calling(CFC) support diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 12b5f32..0cee99f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -56,16 +56,16 @@ This project follows ### Requirement for PRs -- All PRs, other than small documentation or typo fixes, should have an issue associated. If not, please create one. -- Submit small, focused PRs. Keep changes minimal—one concern per PR. -- For bug fixes or features, please provide logs or screenshots after the fix is applied to help reviewers better understand the change. -- Please add corresponding tests for your code change if it is not covered by existing tests. +- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one. +- Small, focused PRs. Keep changes minimal—one concern per PR. +- For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix. +- Please add corresponding testing for your code change if it's not covered by existing tests. ### Large or Complex Changes For substantial features or architectural revisions: -- Open an issue first: Outline your proposal, including design considerations and impact. -- Gather feedback: Discuss with maintainers and the community to ensure alignment and avoid duplicate work. +- Open an Issue First: Outline your proposal, including design considerations and impact. +- Gather Feedback: Discuss with maintainers and the community to ensure alignment and avoid duplicate work ### Code reviews diff --git a/tests/unittests/tools/openapi_tool/openapi_spec_parser/test_rest_api_tool.py b/tests/unittests/tools/openapi_tool/openapi_spec_parser/test_rest_api_tool.py index 74b83d6..968570d 100644 --- a/tests/unittests/tools/openapi_tool/openapi_spec_parser/test_rest_api_tool.py +++ b/tests/unittests/tools/openapi_tool/openapi_spec_parser/test_rest_api_tool.py @@ -61,7 +61,7 @@ class TestRestApiTool: return mock_parser @pytest.fixture - def sample_endpiont(self): + def sample_endpoint(self): return OperationEndpoint( base_url="https://example.com", path="/test", method="GET" )